Skip to content

Suggested fix for ImpfSetTropCyclone.get_countries_per_region() #1105 #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Suggested fix for ImpfSetTropCyclone.get_countries_per_region() #1105 #1106

wants to merge 1 commit into from

Conversation

@spjuhel
Copy link
Collaborator

@spjuhel spjuhel commented Nov 4, 2025

Changes proposed in this PR:

  • Updates the method to correctly return expected values when providing no argument for region, or None or "all".
  • Updates the code for Kosovo in the CountryCode enum to XKO to avoid LookupError.

This PR fixes #1105

PR Author Checklist

PR Reviewer Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emanuel-schmid emanuel-schmid Awaiting requested review from emanuel-schmid emanuel-schmid is a code owner

@chahank chahank Awaiting requested review from chahank chahank is a code owner

@peanutfun peanutfun Awaiting requested review from peanutfun peanutfun is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@spjuhel