[OpenWrt] Fix HostID and HostID2 creation exceptions #1604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reduce the size of the system, OpenWrt contains only one hashing command - `sha256sum`. SHA-256 hash truncation to SHA1 length is allowed by NIST, see: <https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.180-4.pdf>.
OpenWrt uses `dropbear` as a lightweight SSH server. I assume, that all devices with OpenWrt have MAC address (they are routers), so to minimize impact on other OSes, I didn't touch SSH-based HostID generation.
|
Looks good to me. My compliments for how you extended the code with careful attention on the existing parts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of enabling support for OpenWrt, see: #1600.
(more details in commit messages)