Skip to content

Installation: Don't insist on providing GMP #8893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 26, 2025

Conversation

soesau
Copy link
Member

@soesau soesau commented May 15, 2025

Summary of Changes

Removed error when GMP is not found.

Release Management

@afabri
Copy link
Member

afabri commented May 15, 2025

@sloriot can you confirm that boost 1.74.0 has the working multiprecision. And confim that it is boost::mp which is used when GMP is not available.

@MaelRL MaelRL added this to the 6.0.2 milestone May 16, 2025
@sloriot
Copy link
Member

sloriot commented May 19, 2025

@sloriot can you confirm that boost 1.74.0 has the working multiprecision. And confim that it is boost::mp which is used when GMP is not available.

Yes to both questions

@afabri
Copy link
Member

afabri commented May 19, 2025

@sloriot can you confirm that boost 1.74.0 has the working multiprecision. And confim that it is boost::mp which is used when GMP is not available.

Yes to both questions

Do we document that clear enough? For example in Epick and Exact_rational ?

@afabri
Copy link
Member

afabri commented May 19, 2025

Note that the sententence "It is a typedef of another number type. Its exact definition depends on the availability the third-party libraries GMP, Core, and LEDA. CGAL must be configured with at least one of those libraries." is plain wrong.

@afabri
Copy link
Member

afabri commented May 19, 2025

I forgot to give the link

@sloriot
Copy link
Member

sloriot commented May 19, 2025

There isn't a section about boost mp here.

@sloriot
Copy link
Member

sloriot commented May 19, 2025

The section that I did update is that one

@afabri
Copy link
Member

afabri commented May 22, 2025

/build:v0

Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8893/v0/Manual/index.html

@afabri
Copy link
Member

afabri commented May 22, 2025

/force-build:v0

Copy link

There was an error while building the doc:

/home/runner/work/cgal/cgal/Number_types/doc/Number_types/PackageDescription.txt:21: warning: group nt_boost: ignoring title "boost multiprecision" that does not match old title "Boost"

https://github.com/CGAL/cgal/actions/runs/15186349022

@afabri
Copy link
Member

afabri commented May 22, 2025

/force-build:v0

Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8893/v0/Manual/index.html

@sloriot
Copy link
Member

sloriot commented May 26, 2025

Successfully tested in CGAL-6.1-Ic-161

@sloriot sloriot merged commit b8d043f into CGAL:6.0.x-branch May 26, 2025
9 checks passed
@sloriot sloriot deleted the Installation-Dont_insist_on_GMP-GF branch May 26, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants