PMP: Make stitch_borders() deterministic #8890
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afabri
commented
May 14, 2025
| std::cout << hedges_to_stitch.size() " halfedge pairs to stitch on border containing:\n" | ||
| << edge(h, pmesh) << "\n\t" << source(h, pmesh) << "\t(" << get(vpm, source(h, pmesh)) << ")" | ||
| << "\n\t" << target(h, pmesh) << "\t(" << get(vpm, target(h, pmesh)) << ")" << std::endl; | ||
| std::cout << hedges_to_stitch.size() << " halfedge pairs to stitch on border containing:\n" |
There was a problem hiding this comment.
@sloriot can you confirm that bh is the right object here.
There was a problem hiding this comment.
I don't remember but from what I read bh is not in the range. Should be *hedges_to_stitch.begin() for example.
afabri
commented
May 14, 2025
lrineau
reviewed
May 15, 2025
lrineau
reviewed
May 15, 2025
Co-authored-by: Laurent Rineau <Laurent.Rineau@cgal.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR makes the function
CGAL::Polygon_mesh_processing::stitch_borders()deterministic.It was already deterministic for
CGAL::Surface_meshbut not forCGAL::Polyhedron_3as it compared pointers.In case we do not want to change the code, we can also document the existing named parameter
halfedges_keeper.Release Management