Mark variables declared at global scope in headers as 'inline'. #8874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
const
variables declared at global scope have internal linkage, and so if they are declared in a header file, they are replicated in every file that#include
the header. They also can't be the target ofusing
declarations that exports the variable into a C++20 module. This change marks a number of variables withinline
, which gives these variables external linkage, allows the linker to unify all of these variables between different.o
files, and also allows for their use in C++20 modules.There is a separate question whether these variables could or should be
constexpr
instead of justconst
. The difference betweenconstexpr
andconst
has no effect on linkage, and so in the spirit of taking one step at a time, this patch does not address theconstexpr
vsconst
question.This patch fixes #8871. Related to dealii/dealii#18071.
Release Management