-
Notifications
You must be signed in to change notification settings - Fork 1.5k
SMDS_3 - add class Simplicial_mesh_triangulation_3
to ease the use of C3t3
#8868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
janetournois
wants to merge
4
commits into
CGAL:master
Choose a base branch
from
janetournois:SMDS_3-add_c3t3_default-jtournois
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
SMDS_3 - add class Simplicial_mesh_triangulation_3
to ease the use of C3t3
#8868
janetournois
wants to merge
4
commits into
CGAL:master
from
janetournois:SMDS_3-add_c3t3_default-jtournois
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrineau
reviewed
May 2, 2025
Co-authored-by: Laurent Rineau <Laurent.Rineau@cgal.org>
lrineau
reviewed
May 5, 2025
Comment on lines
30
to
46
template<typename K, | ||
typename SubdomainIndex = int, | ||
typename SurfacePatchIndex = int, | ||
typename CurveIndex = int, | ||
typename CornerIndex = int> | ||
using Simplicial_mesh_triangulation_3 = | ||
public CGAL::Triangulation_3<K, | ||
CGAL::Triangulation_data_structure_3< | ||
CGAL::Simplicial_mesh_vertex_base_3<K, | ||
SubdomainIndex, | ||
SurfacePatchIndex, | ||
CurveIndex, | ||
CornerIndex>, | ||
CGAL::Simplicial_mesh_cell_base_3<K, SubdomainIndex, SurfacePatchIndex>, | ||
CGAL::Sequential_tag> | ||
> | ||
{}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My patch was wrong. There is an error in the CI:
/home/runner/work/cgal/cgal/Installation/../SMDS_3/include/CGAL/Simplicial_mesh_triangulation_3.h:36:7: error: expected type-specifier before ‘public’
36 | public CGAL::Triangulation_3<K,
| ^~~~~~
Here is the fix, with a bit a reformatting as well:
Suggested change
template<typename K, | |
typename SubdomainIndex = int, | |
typename SurfacePatchIndex = int, | |
typename CurveIndex = int, | |
typename CornerIndex = int> | |
using Simplicial_mesh_triangulation_3 = | |
public CGAL::Triangulation_3<K, | |
CGAL::Triangulation_data_structure_3< | |
CGAL::Simplicial_mesh_vertex_base_3<K, | |
SubdomainIndex, | |
SurfacePatchIndex, | |
CurveIndex, | |
CornerIndex>, | |
CGAL::Simplicial_mesh_cell_base_3<K, SubdomainIndex, SurfacePatchIndex>, | |
CGAL::Sequential_tag> | |
> | |
{}; | |
template<typename K, | |
typename SubdomainIndex = int, | |
typename SurfacePatchIndex = int, | |
typename CurveIndex = int, | |
typename CornerIndex = int> | |
using Simplicial_mesh_triangulation_3 = | |
CGAL::Triangulation_3<K, | |
CGAL::Triangulation_data_structure_3< | |
CGAL::Simplicial_mesh_vertex_base_3<K, | |
SubdomainIndex, | |
SurfacePatchIndex, | |
CurveIndex, | |
CornerIndex>, | |
CGAL::Simplicial_mesh_cell_base_3<K, SubdomainIndex, SurfacePatchIndex>, | |
CGAL::Sequential_tag | |
> // end of CGAL::Triangulation_data_structure_3 | |
> // end of CGAL::Triangulation_3< | |
{}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example c3t3_example forces the user to have typedefs for cell base, vertex base, Tds, T3...
I suggest to add a new helper type
Simplicial_mesh_triangulation_3
that holds everything needed.Summary of Changes
Add
Simplicial_mesh_triangulation_3
and an exampleRelease Management
Todo :