C++17 implementation of Dispatch_(or_drop)?_output_iterator #8854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a new implementation of `Dispatch_output_iterator` and `Dispatch_or_drop_output_iterator`, using: - derivation from template parameter pack (C++11), - with a using-declaration based on a pack (C++17). And `*_or_drop*` is implemented using an enable-if trick with a boolean template parameter. That new implementation loops around the issue with gcc-15, and fixes issue CGAL#8827. See: - the CGAL CGAL#8827, - and the upstream gcc bug entry https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119859
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
This PR seems fine, now: the Github CI tests pass. @sloriot let us know what you think of the new C++17 implementation of |
sloriot
added a commit
that referenced
this pull request
May 12, 2025
Does not replace #8854 that is a better implementation but currently not fully compatible with older compilers. Also loops around the issue with gcc-15, and fixes issue #8827. See: - the CGAL #8827, - and the upstream gcc bug entry https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119859
Old compiler or not, there was indeed something wrong in the implementation. Fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This is a new implementation of
Dispatch_output_iteratorandDispatch_or_drop_output_iterator, using:And
*_or_drop*is implemented using an enable-if trick with a boolean template parameter.That new implementation loops around the issue with gcc-15, and fixes issue #8827.
See:
Release Management