Skip to content

Double use of citation name #8504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025

Conversation

albert-github
Copy link
Contributor

Based on #8320 and doxygen/doxygen#11157 creating an assertion for builds from scratch when a citation name is used multiple times.

@afabri
Copy link
Member

afabri commented Sep 30, 2024

It would be good to add a duplicate entry so that we can see that it gets catched in the manual testsuite.

@albert-github
Copy link
Contributor Author

Well that would probably be a bit problematic as it has to be in PackageDescription.txt files and we would see it every night in the overview https://cgal.geometryfactory.com/CGAL/Manual_doxygen_test/
Or are you referring to another place?

@afabri
Copy link
Member

afabri commented Sep 30, 2024

You added a duplicate detection feature to a script that is run to build the full documentation.
In order to test your feature we should add a duplicate, and merge this branch in integration.
If your feature works we will see it in the documentation testsuite page.
Then we can remove the duplicate again, and merge this PR in master.

@albert-github
Copy link
Contributor Author

albert-github commented Sep 30, 2024

That would be one scenario. Another would be to do it locally, like I did for testing.
I changed the original problematic ones (#8318), i.e. the ones in

  • Kinetic_space_partition/doc/Kinetic_space_partition/PackageDescription.txt
  • Kinetic_surface_reconstruction/doc/Kinetic_surface_reconstruction/PackageDescription.txt

to cgal:ol-kinetic and ran the documentation generation locally so that I got the error.
In my opinion no need to create 2 extra commits (there are enough commits in CGAL already ...).

@afabri afabri added this to the 6.1-beta milestone Oct 8, 2024
@afabri afabri requested a review from sloriot October 8, 2024 11:27
Based on CGAL#8320 and doxygen/doxygen#11157 creating an assertion for builds from scratch when a citation name is used multiple times.
(doxygen cannot catch these here as they are directly written into html code).
@sloriot sloriot force-pushed the feature/bug_double_cite branch from 558af4b to 837be25 Compare May 7, 2025 07:23
@sloriot
Copy link
Member

sloriot commented May 7, 2025

Locally tested, works great. Thanks @albert-github

@sloriot sloriot merged commit 8c9f53c into CGAL:master May 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants