Skip to content

Add an assertion to the discrete_space function and a death test #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tpadioleau
Copy link
Member

No description provided.

@tpadioleau tpadioleau self-assigned this Jun 19, 2025
@tpadioleau tpadioleau linked an issue Jun 19, 2025 that may be closed by this pull request
@tpadioleau tpadioleau force-pushed the 874-raise-error-when-using-ddcdiscrete_space-if-not-initialised branch from 5882427 to 2a2d7b8 Compare June 19, 2025 20:09
@tpadioleau tpadioleau force-pushed the 874-raise-error-when-using-ddcdiscrete_space-if-not-initialised branch from 2a2d7b8 to 1ca92ea Compare June 19, 2025 20:23
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.80%. Comparing base (a40f2d3) to head (6584eaf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
include/ddc/discrete_space.hpp 50.00% 1 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
- Coverage   89.92%   89.80%   -0.13%     
==========================================
  Files          55       55              
  Lines        2859     2863       +4     
  Branches      974      976       +2     
==========================================
  Hits         2571     2571              
- Misses         92       95       +3     
- Partials      196      197       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

EmilyBourne
EmilyBourne previously approved these changes Jun 20, 2025
EmilyBourne
EmilyBourne previously approved these changes Jun 20, 2025
Co-authored-by: Emily Bourne <louise.bourne@gmail.com>
@tpadioleau tpadioleau force-pushed the 874-raise-error-when-using-ddcdiscrete_space-if-not-initialised branch from 9578038 to 6584eaf Compare June 20, 2025 15:41
@tpadioleau tpadioleau merged commit 771c1bb into main Jun 20, 2025
15 checks passed
@tpadioleau tpadioleau deleted the 874-raise-error-when-using-ddcdiscrete_space-if-not-initialised branch June 20, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raise error when using ddc::discrete_space if not initialised
2 participants