UI: New text-strings preview mode #1051
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!props.content) return ""; | ||
| if (props.mode === "raw") { | ||
| if (props.content instanceof ArrayBuffer) | ||
| return new TextDecoder().decode(props.content); | ||
| else return props.content; | ||
| } else if (props.mode === "text") { |
There was a problem hiding this comment.
Currently, there are too many if-logic blocks here. I suggest creating separate utility functions for each mode — 'raw', 'text', and 'hex' to handle the value for each of them individually.
| else buffer = new TextEncoder().encode(props.content); | ||
|
|
||
| const MIN_LENGTH = 4; | ||
| let result: string[] = []; |
There was a problem hiding this comment.
Suggested change
| let result: string[] = []; | |
| const result: string[] = []; |
Comment on lines
+18
to
+23
| const selectedStyle = { | ||
| fontWeight: selected ? "bold" : "normal", | ||
| pointerEvents: (selected ? "none" : "auto") as | ||
| | "none" | ||
| | "auto", | ||
| }; |
There was a problem hiding this comment.
Suggested change
| const selectedStyle = { | |
| fontWeight: selected ? "bold" : "normal", | |
| pointerEvents: (selected ? "none" : "auto") as | |
| | "none" | |
| | "auto", | |
| }; | |
| const styles = { fontWeight: selected ? "bold" : "normal" }; |
| }; | ||
|
|
||
| return ( | ||
| <span className="nav-item" style={selectedStyle} key={mode}> |
There was a problem hiding this comment.
Suggested change
| <span className="nav-item" style={selectedStyle} key={mode}> | |
| <span className="nav-item" style={styles} key={mode}> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
What is the current behaviour?
Only raw and hex mode in sample preview.
What is the new behaviour?
HexViewtoObjectPreviewTest plan
Go to sample preview and change mode on some files.
Screencast.from.2025-07-23.12-07-29.webm