Skip to content

Limit exposed relationships type-wise to 100 elements #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

psrok1
Copy link
Member

@psrok1 psrok1 commented Mar 4, 2025

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?

This PR addresses the same problem as #881 and #1008.

What is the new behaviour?

If there are more relationships than 100 within a specific type, only the latest 100 are shown via API. Limiting must be done typewise because MWDB UI divides relationships into object types:

image

So there is a possibililty that with 100+ parent samples, blob relationship won't be shown which is surprising and incorrect behavior.

If there is 100 or more relationships within a specific type, MWDB shows additional link to query that allows to search for all related objects of that type.

image

Usually the relationships within type are in specific direction, that's why MWDB UI tries to deduce whether "parent query" or "child query" should be shown.

@psrok1 psrok1 merged commit f4260ac into master Mar 4, 2025
12 checks passed
@psrok1 psrok1 deleted the fix/limited-relationships branch March 4, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant