fix: missing immunization section #102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ave null flavors or have entries
angelathe
requested review from
austin-hall-skylight,
gordonfarrell and
nickclyde
and removed request for
a team
austin-hall-skylight
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
PR title: Remember to name your PR descriptively and follow conventional commits!
Summary
The composition section was missing entries in the immunization section for several eCRs -- this PR fixes that.
eCR_RR_combined_3_1.xml: The immunizations section had multiple template OIDs for both the entries optional & entries required immunization section. Updated theComposition.liquidfile to check for all.eCR_full.xml: The XML was using the wrong template OID for the Immunizations section -- that was fixed in the file.eicr04152020.xml: The immunizations section existed, but had a nullFlavor/had no entries. UpdatedComposition.liquidso that when it iterates through each section, it checks that the section either 1) doesn't have a nullFlavor, or 2) has entries before building out the section.Related Issue
Fixes CDCgov/dibbs-ecr-viewer#1137
Viewer PR: CDCgov/dibbs-ecr-viewer#1207
Acceptance Criteria
Additional Information
N/A
Checklist
dibbs-ecr-viewerPR & checked that things work on the front-end.dibbs-ecr-viewer)dibbs-ecr-viewerPR is created and validated. When both have been approved:dibbs-fhir-converterdibbs-ecr-viewerwith the updated release branch number.