Skip to content

Deploy: Add Terraform configuration and infrastructure setup for Digital Ocean #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 5, 2025

Conversation

ByteMeDirk
Copy link
Owner

No description provided.

@ByteMeDirk ByteMeDirk added this to the Data Platform milestone Jun 4, 2025
@ByteMeDirk ByteMeDirk requested a review from Copilot June 4, 2025 18:48
@ByteMeDirk ByteMeDirk self-assigned this Jun 4, 2025
@ByteMeDirk ByteMeDirk added the enhancement New feature or request label Jun 4, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces Terraform-based infrastructure setup for Digital Ocean, extracts API key retrieval into a dedicated function, and updates related documentation and CI tooling.

  • Add Terraform configuration files (main.tf, variables.tf, database.tf, outputs.tf) and example tfvars
  • Extract get_newsapi_key from get_db_config in env.py
  • Update documentation (INFRASTRUCTURE.md, DEPLOYMENT.md, README.md) and streamline CI configs

Reviewed Changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
semantic_medallion_data_platform/config/env.py Move NewsAPI key retrieval into its own function
infrastructure/terraform/variables.tf Define variables for Digital Ocean provider
infrastructure/terraform/terraform.tfvars.example Provide example tfvars for user configuration
infrastructure/terraform/outputs.tf Define Terraform outputs for DB connection details
infrastructure/terraform/main.tf Configure Terraform provider for Digital Ocean
infrastructure/terraform/database.tf Define PostgreSQL resources on Digital Ocean
docs/INFRASTRUCTURE.md Document Terraform setup and resources
docs/DEPLOYMENT.md Document deployment steps including Terraform and app setup
README.md Add Terraform setup section and update tech stack
.pre-commit-config.yaml Comment out large file check in pre-commit hooks
.github/workflows/pr-tests.yml Add GitHub Actions workflow for PR tests
.github/workflows/ci-cd.yml Remove deprecated CI/CD pipeline file
Files not reviewed (1)
  • infrastructure/terraform/.terraform.lock.hcl: Language not supported
Comments suppressed due to low confidence (2)

README.md:33

  • The README references a setup.sh script under infrastructure/terraform/ that isn't present in the repo. Either add the script or remove the entry.
│   └── terraform/                # Terraform configuration for Digital Ocean

infrastructure/terraform/terraform.tfvars.example:12

  • [nitpick] The example uses semantic-data-platform with dashes, but the default project_name is Semantic Data Platform. Align naming formats to avoid confusion.
# project_name = "semantic-data-platform"

ByteMeDirk and others added 4 commits June 4, 2025 20:51
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ByteMeDirk ByteMeDirk merged commit 3ac1de5 into main Jun 5, 2025
1 check passed
@ByteMeDirk ByteMeDirk deleted the feature/base-iac branch June 5, 2025 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant