Add configurable timeout for brancher creation #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a new option, `hn_brancher_timeout`, to configure the timeout for brancher Hypernode creation. Updated the DeployRunner to utilize this option and added relevant documentation to the README for its usage. The default timeout remains 1500 seconds if not explicitly set.
poespas
reviewed
Jun 10, 2025
| @@ -34,6 +34,7 @@ class DeployRunner | |||
| { | |||
| public const TASK_BUILD = 'build'; | |||
| public const TASK_DEPLOY = 'deploy'; | |||
| public const OPTION_HN_BRANCHER_TIMEOUT = 'hn_brancher_timeout'; | |||
There was a problem hiding this comment.
This would optimally go to the hypernode-deploy-configuration so that it becomes available for autocomplete in IDEs.
There was a problem hiding this comment.
Perhaps an environment variable would be more fitting?
|
Hi @gunneman ! Thank you for your Pull request, highly appreciated. We left one feedback point and sadly will require a second Pull Request to the hypernode-deploy-configuration repository. Please let us know if you have questions about this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a new option,
hn_brancher_timeout, to configure the timeout for brancher Hypernode creation. Updated the DeployRunner to utilize this option and added relevant documentation to the README for its usage. The default timeout remains 1500 seconds if not explicitly set.