Skip to content

onChange type #4043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

onChange type #4043

wants to merge 11 commits into from

Conversation

STRd6
Copy link
Contributor

@STRd6 STRd6 commented Apr 25, 2025

Description

Fix TS types for onChange, allowing string and non-async functions.

Copy link

changeset-bot bot commented Apr 25, 2025

⚠️ No Changeset found

Latest commit: 503f882

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

gitguardian bot commented Apr 25, 2025

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9071768 Triggered Generic High Entropy Secret 54a6833 packages/sdks-tests/src/specs/slot-with-symbol.ts View secret
2708648 Triggered Generic High Entropy Secret 33e7518 examples/angular-gen2/src/environments/environment.ts View secret
14200383 Triggered Generic High Entropy Secret bf23f1f packages/core/src/builder.class.test.ts View secret
14200384 Triggered Generic High Entropy Secret bf23f1f packages/core/src/builder.class.test.ts View secret
14200385 Triggered Generic High Entropy Secret 568397e packages/core/src/builder.class.test.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

nx-cloud bot commented Apr 25, 2025

View your CI Pipeline Execution ↗ for commit 503f882.

Command Status Duration Result
nx test @e2e/qwik-city ✅ Succeeded 10m 8s View ↗
nx test @e2e/nuxt ✅ Succeeded 9m 12s View ↗
nx test @e2e/nextjs-sdk-next-app ✅ Succeeded 9m 4s View ↗
nx test @e2e/angular-19-ssr ✅ Succeeded 7m 54s View ↗
nx test @e2e/angular-16 ✅ Succeeded 7m 30s View ↗
nx test @e2e/angular-16-ssr ✅ Succeeded 7m 23s View ↗
nx test @e2e/react-sdk-next-15-app ✅ Succeeded 7m 6s View ↗
nx test @e2e/react-sdk-next-14-app ✅ Succeeded 7m 1s View ↗
Additional runs (36) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-04-25 19:35:11 UTC

@STRd6 STRd6 enabled auto-merge (rebase) April 25, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant