-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Portal app creation updates #15980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andz-bb
wants to merge
22
commits into
master
Choose a base branch
from
portal-app-creation-updates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Portal app creation updates #15980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
… new templates modal
aptkingston
reviewed
May 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work Andy! This is much neater and speeds things up.
Still reviewing, but a few UX things I think we could improve so far:
- When using a template we could generate nicer names. Right now it's all lowercase and. I think something like
Expense Approval App 1
would be better.
- For subsequent apps that don't get the sample data or screen, it still throws you into the design section after creation. 2 of the 3 screen options (table and form) can't actually be used because there's no data at all. I understand not wanting the sample screen for subsequent apps, but personally I'd probably keep the sample data for all apps since it's completely harmless and can be deleted if not wanted. Either that or we need to either disable those screen templates until data exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Onboarding improvements
App creation
builder/portal/apps/create
andbuilder/portal/apps/templates
screens have been removed. Instead, apps can be created or imported directly from the main apps screen.Launchcontrol
improved onboarding, streamlined app creation, new templates flow
Feature branch env
Feature Branch Link