Restructuring headers and updating makevars in R-package #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cannot find header files during installation from GitHub. Asked question https://stackoverflow.com/q/58189830/7456798 on stackoverflow. |
|
Works with travis: dependent upon before_install:
- cp -r inst/include R-package/include
- cd R-packageand modifying Will still fail with Do not merge pull-request before functional with above function or on CRAN (or some other easy way to install). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Header files are base C++, which distributions in R, Py, Java, ... will read from. They should be located under root, not under R-package