BUG: Fix crashing issue with string constants. Add CPR/CRC Binary EBSD Reader #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
…#26) * BUG: Use StringLiteral class to avoid crashes on launch due to unintialized std::string constants * COMP: Add missing #include directive for tbb task_group --------- Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
imikejackson
added a commit
that referenced
this pull request
Nov 8, 2024
…D Reader (#28) * VERSION: Update to 1.0.34 * BUG: Fix crashing due to use of std::string as a constant in headers. (#26) * COMP: Add missing #include directive for tbb task_group * READER: Implement Aztec .cpr/.crc reader for EBSD data. (#27) * Fix Xcode 16 crash on start up. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net> --------- Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
imikejackson
added a commit
that referenced
this pull request
Nov 8, 2024
…D Reader (#28) * VERSION: Update to 1.0.35 * BUG: Fix crashing due to use of std::string as a constant in headers. (#26) * COMP: Add missing #include directive for tbb task_group * READER: Implement Aztec .cpr/.crc reader for EBSD data. (#27) * Fix Xcode 16 crash on start up. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net> --------- Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.