Skip to content

Rename elements/jets.c #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rename elements/jets.c #298

wants to merge 1 commit into from

Conversation

roconnor-blockstream
Copy link
Collaborator

I forgot that MSVC doesn't let you have files with the same name, even if they are in different directories.

@roconnor-blockstream
Copy link
Collaborator Author

I've tested this in ElementsProject/elements#1459, where the MSVC build now times out instead of failing. :/

Copy link
Contributor

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK dd11891

windows ci task timeout is unrelated, so this does fix the msvc build issue

@apoelstra
Copy link
Contributor

Need to update the #include in Haskell/cbits/elements/jets.c

I forgot that MSVC doesn't let you have files with the same name, even if they are in different directories.
@roconnor-blockstream
Copy link
Collaborator Author

Fixed

Copy link
Contributor

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK cad9a63; successfully ran local tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants