Fixup cabal repl Simplicity #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@apoelstra I don't really know a good way of running |
|
Might be time for some github CI? I can take a look, what kind of test jobs should be run? |
|
@apoelstra has in own CI in NixOS, whose details we should probably merge into this project itself. |
|
My local CI is pretty heavy. I'm not sure it's reasonable to merge into this project. But if you want it it's here: https://github.com/apoelstra/local-nix-ci/blob/main/BlockstreamResearch.Simplicity.check-pr.nix |
|
Thanks I’ll take a look! |
roconnor-blockstream
force-pushed
the
cabal-repl
branch
from
09cf88b to
303a49a
Compare
Recent refactoring in 1a4006c inserted txEnv.c into the wrong place. This caused `cabal repl Simplicity` to fail.
roconnor-blockstream
force-pushed
the
cabal-repl
branch
from
303a49a to
89bbd57
Compare
|
rebased |
|
My local CI does not run |
|
Just to make sure I didn't somehow break something else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent refactoring in 1a4006c inserted txEnv.c into the wrong place. This caused
cabal repl Simplicityto fail.