Skip to content

Commit 9ffc9c6

Browse files
authored
Revert node engine change (#1002)
1 parent aba2011 commit 9ffc9c6

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

.github/workflows/test.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
build:
1111
strategy:
1212
matrix:
13-
node: [14, 16, 18, 19]
13+
node: [10, 12, 14, 16, 18, 19]
1414
os: [ubuntu-22.04]
1515
include:
1616
# single mac test due to minute multipliers
@@ -30,12 +30,14 @@ jobs:
3030
with:
3131
node-version: ${{ matrix.node }}
3232
cache: "npm"
33+
- name: Update node-gyp
34+
run: npm install --global node-gyp@latest
3335
- name: Install Windows packages
3436
if: runner.os == 'Windows'
3537
run: ./win_install.ps1
3638
- name: Build
3739
run: npm ci
3840
# skipping on windows for now due to Make / mocha exit code issues
3941
- name: Test
40-
if: runner.os != 'Windows'
42+
if: runner.os != 'Windows' && matrix.node != 10
4143
run: npm test

package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "node-rdkafka",
3-
"version": "v2.14.5",
3+
"version": "v2.14.6",
44
"description": "Node.js bindings for librdkafka",
55
"librdkafka": "1.9.2",
66
"main": "lib/index.js",
@@ -43,6 +43,6 @@
4343
"nan": "^2.17.0"
4444
},
4545
"engines": {
46-
"node": ">=14.0.0"
46+
"node": ">=6.0.0"
4747
}
4848
}

0 commit comments

Comments
 (0)