Skip to content

Commit aba2011

Browse files
authored
Add Windows and Mac to CI workflow (#998)
1 parent 5f0fa56 commit aba2011

File tree

3 files changed

+26
-17
lines changed

3 files changed

+26
-17
lines changed

.github/workflows/test.yml

Lines changed: 24 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Test node-rdkafka
1+
name: Build & Test
22

33
on:
44
push:
@@ -10,16 +10,32 @@ jobs:
1010
build:
1111
strategy:
1212
matrix:
13-
version: [14, 16, 18, 19]
14-
runs-on: ubuntu-latest
13+
node: [14, 16, 18, 19]
14+
os: [ubuntu-22.04]
15+
include:
16+
# single mac test due to minute multipliers
17+
# https://docs.github.com/en/billing/managing-billing-for-github-actions/about-billing-for-github-actions
18+
- node: 18
19+
os: macos-12
20+
# single windows test due to node.js 14 node-gyp / vs 2022 issues
21+
- node: 18
22+
os: windows-2022
23+
runs-on: ${{ matrix.os }}
1524
steps:
1625
- uses: actions/checkout@v3
1726
with:
1827
submodules: recursive
19-
- uses: actions/setup-node@v3
28+
- name: Install Node ${{ matrix.node }} in ${{ runner.os }}
29+
uses: actions/setup-node@v3
2030
with:
21-
node-version: ${{ matrix.version }}
31+
node-version: ${{ matrix.node }}
2232
cache: "npm"
23-
- run: npm ci
24-
- run: npm test
25-
name: test
33+
- name: Install Windows packages
34+
if: runner.os == 'Windows'
35+
run: ./win_install.ps1
36+
- name: Build
37+
run: npm ci
38+
# skipping on windows for now due to Make / mocha exit code issues
39+
- name: Test
40+
if: runner.os != 'Windows'
41+
run: npm test

win_install.bat

Lines changed: 0 additions & 9 deletions
This file was deleted.

win_install.ps1

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
choco install openssl.light
2+
choco install make

0 commit comments

Comments
 (0)