Bitshala Bitcoin Core PR Review Club

This is a PR review club organized by Bitshala, with inspiration from Bitcoin Core Reviews.

About the Club

This club meets biweekly on Thursdays at IST 19:00 (UTC 13:30) and is open to all. Our mission is to make Bitcoin Core development more accessible to newcomers by providing a supportive environment for PR reviews and discussions.

• Joining link: Shared in the #announcements channel of Bitshala Discord
• Calendar: Subscribe to our Google Calendar or add this ICS file to your calendar application

Participating with video isn't mandatory. The calls are recorded and published for educational purposes.

Table of Contents

• Next Review Club
• How To Participate
• Request a PR Review
• Prerequisites
  • Basics
  • Further Reading
• Previous Review Club Sessions

Next Review Club

• Date: May 8, 2025
• Title: TBA
• PR Details: TBA

How To Participate

1. Keep an eye on this README for weekly updates
2. Join the Bitshala Discord, where PR-related discussions take place and meeting links are shared
3. Each review topic is detailed in an Issue - use the comments to post questions and discuss the PR
4. Review process:
   • Check out the PR
   • Go through the "Notes and Questions" in the topic details
   • Prepare your answers before joining the call
   • Join the Jitsi room at the scheduled time
   • Submit your final review to the original Bitcoin Core PR thread

Request a PR Review

If you'd like to have your Bitcoin Core PR reviewed in our club:

1. Create an issue with the following information:

   • Title: "PR Review Request: [Your PR Title]"
   • PR Link: Link to your Bitcoin Core PR
   • Brief description of what your PR does
   • Areas of feedback you're looking for
   • Any specific questions you have about your implementation

2. Bitshala team will review your request and schedule it for an upcoming review session if appropriate

3. You're encouraged to attend the session when your PR is reviewed to provide context and answer questions

Prerequisites

If you're a first-time participant or haven't reviewed Core PRs before, you'll find these resources helpful:

Basics

• Common operational steps of Core review Process: YouTube Code available here
• Bitcoin Core Codebase Introductory Tour: YouTube

Further Reading

• Contributing to Bitcoin Core: doc
• Developer Notes: doc
• Intro to Bitcoin Core Dev: doc
• Contributing to Bitcoin Core, a personal account: doc
• Onboarding to Bitcoin Core: doc
• From "Hello World" to Bitcoin Core: doc

Previous Review Club

index	date	PR notes/discussions	video	tag
56	5 Jun 2025	Add mutation check inside compact block's FillBlock		p2p
55	22 May 2025	BIP-348 (OP_CHECKSIGFROMSTACK) (regtest only)	link	script
54	24 Apr 2025	Bitcoin-Core v29.0	link	release testing
53	10 Apr 2025	Clang/LLVM based coverage generation	link	build
52	13 Mar 2025	fuzz: split coinselection harness		fuzz tests
51	27 Feb 2025	psbt add non-default sighash types to PSBTs and unify sighash type match checking	link	p2p tests
50	30 Jan 2025	test, Call generate RPCs through test framework only, qa: Improve framework.generate* enforcement (#31403 follow-up)	link	rpc tests
49	16 Jan 2025	add missing segwitv1 test cases to script_standard_tests and exploring v3 transaction relay	link	p2p rbf
48	1 Jan 2025	fuzz: Abort if system time is called without mock time being set	link	fuzz tests
47	19 Dec 2025	Execute Discover() when bind=0.0.0.0 or :: is set	link	p2p tests
46	5 Dec 2024	handle invalid -rpcbind port	link	rpc p2p
45	26 Nov 2024	(test) clarify timewarp grace period griefing attack		rpc p2p
44	21 Nov 2024	Settxfeerate	link	rpc wallet
43	7 Nov 2024	Review Club: Drop miniupnp dependency	link	p2p rpc
42	24 Oct 2024	Prevention of Stalling when close to the tip	link	p2p
41	10 Oct 2024	P2P - Increase tx relay rate		p2p
40	26 Sept 2024	Review Club : PSBT input utxo population	link	p2p rpc
39	19 Sept 2024	Review Club: p2p - Tracing in Bitcoin Core		p2p tracing
38	5 Sept 2024	rpc: Add test-only RPCs under -test= flag		p2p
37	22 Aug 2024	p2p: Increase inbound capacity for block-relay only connections	link	p2p
36	8 Aug 2024	RPC : Fix -norpcwhitelist, -norpcallowip, and similar corner case behavior Aug 8 2024	link	rpc
35	25 July 2024	consensus: Store transaction nVersion as uint32_t #29325		consensus
34	11 July 2024	[Part 3/3: Writing unit tests and fuzz tests] p2p - Fill reconciliation sets		BIP330 erlay
33	13 June 2024	[Part 2/3] p2p: Fill reconciliation sets (Erlay) attempt 2 #30116		BIP330 erlay
32	23 May 2024	[Part 1/3: Introduction] p2p: Fill reconciliation sets (Erlay) attempt 2 #30116	link	BIP330 erlay
31	25 April 2024	BIP 330 review		BIP330 erlay
30	11 April 2024	test: refactor: introduce and use calculate_input_weight helper #29777		test refactor
29	28 March 2024	v27.0 testing		testing guide
28	14 March 2024	follow up ideas for p2p: Allow whitelisting manual connections #27114		p2p net whitelist
27	22 Feb 2024	follow up ideas for test: Fix SegwitV0SignatureMsg nLockTime signedness #29400		good first issue test locktime
26	8 Feb 2024	rpc: parse legacy pubkeys consistently with specific error messages #28336		test rpc
25	25 Jan 2024	test: p2p: check disconnect due to lack of desirable service flags #29279		test p2p
24	4 Jan 2024	test: Use test framework utils in functional tests #28528	link	test util
23	21 Dec 2023	refactor: share and use GenerateRandomKey helper #28455	link	test refactor
22	07 Dec 2023	[Part 2/2] Functional tests for v2 P2P encryption #24748	link	test p2p
21	16 Nov 2023	[Part 1/2: Introduction] Functional tests for v2 P2P encryption #24748	link	test p2p
20	07 Sep 2023	net: transport abstraction	link	p2p
19	24 Aug 2023	crypto: more Span<std::byte> modernization & follow-ups	link	crypto modern c++
18	03 Aug 2023	Silent Payments: Implement BIP352		wallet silent-payment
17	20 July 2023	Miniscript support in Output Descriptors #24148 (Part 2)	link	wallet miniscript descriptor
16	06 July 2023	Miniscript support in Output Descriptors #24148 (Part 1)	link	wallet miniscript descriptor
15	22 June 2023	BIP-325: Signet [consensus] #18267	link	consensus Signet validation tests
14	8 June 2023	Introduce secp256k1 module with field and group classes to test framework #26222	link	crypto functional test framework
13	25 May 2023	Add importmempool RPC #27460		rpc mempool
12	18 May 2023	When a block is disconnected, update transactions that are no longer conflicted #27145	link	wallet
11	13 April 2023	Skip netgroup diversity of new connections for tor/i2p/cjdns #27374	link	p2p netgroup
10	6 April 2023	Add Single Random Draw as an additional coin selection algorithm #17526	link	wallet coin selection
9	23 March 2023	Allow whitelisting outgoing connections #27114	link	p2p whitelist
8	16 March 2023	Add foreign_outputs metadata to support CoinJoin transactions #25991	link	wallet coinjoin
7	9 March 2023	Activation logic for testing consensus changes #16	link	bitcoin inquisition consensus soft forks
6	23 Feb 2023	Prevent block index fingerprinting by sending additional getheaders messages #24571		p2p fingerprinting
5	16 Feb 2023	Track AddrMan totals by network and table, improve precision of adding fixed seeds #26847	link	p2p addrman
4	9 Feb 2023	Add 'sendall' RPC née sweep #24118	link	wallet RPC
3	26 Jan 2023	Reduce resource usage for inbound block-relay-only connections #22778		p2p
2	19 Jan 2023	Manual block-relay-only connections with addnode #24170	link	p2p rpc
1	12 Jan 2023	Add coverage for dust mempool policy (-dustrelayfee setting) #26631		test mempool