Skip to content

Add layout logic diagrams for the block clock #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

GBKS
Copy link
Contributor

@GBKS GBKS commented Jan 8, 2024

Defines and visualizes the logic of how the block clock adjusts to varying screen sizes. Feedback appreciated.

This came up in conversations in this PR.

Defines and visualizes the logic of how the block clock adjusts to varying screen sizes.
@GBKS GBKS added documentation Improvements or additions to documentation design labels Jan 8, 2024
@GBKS GBKS self-assigned this Jan 8, 2024
@GBKS GBKS merged commit 21c8fc5 into gh-pages Jan 8, 2024
@mouxdesign
Copy link
Contributor

mouxdesign commented Jan 9, 2024

This looks great, can especially see it being very useful developers as well as future contributors. Also ensures the quality of the blockclock among various devices.

When reading the content, it came through that the info for the various sizes were in 4 bigger buckets. An idea could be to state those more intentionally which might help with readers who are trying to pull the information fast. Not a must as the content is 100% understandable as is. The buckets that came through from reading:

Default

  • Network indicator positioning: center below clock
  • Block clock size: 200x200px
  • Padding: 30px
  • Top bar height: 46px

Showcase mode

  • Network indicator positioning: center below clock
  • Block clock size: 200x200px
  • Padding: 30px
  • Top bar height: ?

Smaller sizes (height < 400)

  • Network indicator positioning: top-left corner
  • Block clock size: 200x200px
  • Padding: ?
  • Top bar height: 46px

Even smaller

  • Network indicator positioning: top-left corner
  • Block clock size: Shrinks smaller than 200x200px
  • Padding: Minimum: 26px
  • Top bar height: 36px

@GBKS GBKS deleted the Add-block-clock-layout-logic branch June 26, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants