fix null ptr deref #1528
Merged
fix null ptr deref #1528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`confirm_gesture_create` was called with `NULL` as parent, so `ui_util_position_right_top(parent, confirm_gesture);` passed NULL, and the function derefed NULL to compute the position. Though undefined behavior technically, 0 is a valid pointer in the BitBox02 (start of bootloader), so some bytes slightly offset from 0 were used for the positions. None of that impacted the device behavior though as the positioning of the component was not needed in the first place. The component has a custom _render function that renders the confirm arrows in the right location without looking at `component->position`, so we can just remove the offendling line. The parent param is removed as it is unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
confirm_gesture_createwas called withNULLas parent, soui_util_position_right_top(parent, confirm_gesture);passed NULL, and the function derefed NULL to compute the position.Though undefined behavior technically, 0 is a valid pointer in the BitBox02 (start of bootloader), so some bytes slightly offset from 0 were used for the positions.
None of that impacted the device behavior though as the positioning of the component was not needed in the first place. The component has a custom _render function that renders the confirm arrows in the right location without looking at
component->position, so we can just remove the offendling line.The parent param is removed as it is unused.