factorysetup: don't skip BLE if already flashed #1500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
replaced by #1501 |
If the BLE boot check failed further below, repeating the factory setup made it report success, as _verify_ble() only checks if the BLE firmware was flashed properly already, and the boot check is skipped in that case. For now we simply remove this check so every attempt tries the whole BLE setup & verification procedure. To be refactored later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the BLE boot check failed further below, repeating the factory setup made it report success, as _verify_ble() only checks if the BLE firmware was flashed properly already, and the boot check is skipped in that case.
For now we simply remove this check so every attempt tries the whole BLE setup & verification procedure. To be refactored later.