Skip to content

frontend: refactor send into a functional component #3439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

thisconnect
Copy link
Collaborator

@thisconnect thisconnect commented Jul 2, 2025

No description provided.

@thisconnect thisconnect requested a review from shonsirsha July 2, 2025 15:17
@thisconnect thisconnect force-pushed the frontend-refactor-send branch 2 times, most recently from d57175c to bc12b7e Compare July 9, 2025 06:21
Since the BitBoxApp uses mempool.space as default fee estimator,
these types were missing.

Commit that introduced mempool.space fee estimator:
- bd52d93
Send to functional component refactoring introduced a bug that the
FeeTarget component always resets to "Normal" fee after changing
anything in the Send form.
@thisconnect thisconnect force-pushed the frontend-refactor-send branch from bc12b7e to 46868cf Compare July 10, 2025 08:40
@thisconnect thisconnect marked this pull request as ready for review July 10, 2025 08:41
Copy link
Collaborator

@shonsirsha shonsirsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants