Loose type check between Integer and Float. Both of them are the same in the javascript context. #36
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoheiMune
changed the title
yoheiMune
changed the title
|
@BinaryMuse |
|
I'm not 100% sure this is per spec (that arrays can contain both floats and ints if the underlying language treats them the same). Curious if @mojombo has thoughts. Even if not, I could imagine a "loose mode" or something that might allow this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I got the error at loading a toml file below.
In JS context, both
FloatandIntegerare the same type -Number, so I think, there is no need to distinguish between them.I hope you check my change.
Thank you.