Fix: Ensure emptyMsgOnFail is triggered on all errors #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution. I will take a look at it and merge it when everything looks good! |
|
I just merged your PR with develop so in the next version the fix will be included. |
|
Thank you! Happy to help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issues are addressed by this Pull Request?
This Pull Request addresses issue #517.
What does this Pull Request change?
The change corrects the behavior of the
emptyMsgOnFailoption in themodbus-flex-getternode. Previously, when an error occurred during message handling, the functionmbBasics.sendEmptyMsgOnFailwas being called with an incorrect message reference (msg). This prevented the node from correctly sending an empty message on failure.The fix consists of changing the call from:
To:
This ensures the original input message is passed, restoring the expected behavior of emitting an empty message when a failure occurs.
Does this Pull Request introduce any potentially breaking changes?
No breaking changes are introduced. This is a bugfix that restores previously expected functionality for users relying on
emptyMsgOnFail. Existing configurations and integrations will continue to work as before.