Skip to content

(Refactor) Langfuse - remove prepare_metadata, langfuse python SDK now handles non-json serializable objects #7925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 23, 2025

Conversation

ishaan-jaff
Copy link
Contributor

@ishaan-jaff ishaan-jaff commented Jan 22, 2025

(Refactor) Langfuse - remove prepare_metadata, langfuse python SDK now handles non-json serializable objects

  • Added e2e tests for sending langfuse specific metadata to litellm
  • removed recursive prepare_metadata code block on litellm. This was redundant and langfuse python sdk already gracefully handles metadata that is not json serializable
  • use simple helpers to check if langfuse sdk version supports tags etc

Relevant issues

Type

🧹 Refactoring
✅ Test

Changes

[REQUIRED] Testing - Attach a screenshot of any new tests passing locally

If UI changes, send a screenshot/GIF of working UI fixes

  • e2e test with non json serializable data

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 5:18am

@ishaan-jaff ishaan-jaff merged commit 53a3ea3 into main Jan 23, 2025
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Langfuse - Error trace when logging
1 participant