-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix(test_exceptions.py): move exception tests #11501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
colesmcintosh
wants to merge
12
commits into
BerriAI:main
Choose a base branch
from
colesmcintosh:429-fireworks-mapping
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ex patterns for improved accuracy. Fallback to original logic if regex fails. Update import statement for verbose_logger.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ng regex patterns, relying on string checks instead. This change enhances performance and maintains functionality.
…eptions.py` to clean up the codebase.
…exceptions.py` to streamline the codebase and improve readability.
… to enhance clarity and maintainability.
…ary imports to improve code clarity and maintainability.
ishaan-jaff
requested changes
Jun 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes requested pls.
@@ -5,7 +5,7 @@ | |||
import httpx | |||
|
|||
import litellm | |||
from litellm._logging import verbose_logger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we not change this file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
fix(test_exceptions.py): move exception tests
Relevant issues
Improves rate limiting error detection across different LLM providers by replacing basic string matching with comprehensive regex patterns.
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/
directory, Adding at least 1 test is a hard requirement - see detailsmake test-unit
Type
🐛 Bug Fix
Changes
Summary
Move test_exceptions.py into tests/test_litellm/litellm_core_utils
What Changed
Why This Matters
Testing
test_fireworks_ai_exception_mapping
test continues to passFiles Modified