Suspected logic bug in 'get_optional_params'

[peteski22]

Bug: get_optional_params

Draft PR for potential logic bug in get_optional_params (where the condition custom_llm_provider == "ollama" means it will only ever be ollama).

There was also a case where function_call was the only thing present in the non_default_params but the code didn't check/try to get the value to set it as optional_params["functions_unsupported_model"].

if (
  "functions" in non_default_params
  or "function_call" in non_default_params
  or "tools" in non_default_params
):

The PR adjusts this behaviour such that it is the same regardless of whether custom_llm_provider is ollama or not in the list of openai_compatible_providers.

I had to make a judgement call (so happy to get feedback here) that since the if/elif statement for ollama checked tools then functions, that function_call would come after those two. So the order of precedence is:

tools > functions > function_call

Relevant issues

Refs: #10244

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

• I have Added testing in the tests/litellm/ directory, Adding at least 1 test is a hard requirement - see details
• I have added a screenshot of my new test passing locally
• My PR passes all unit tests on (make test-unit)[https://docs.litellm.ai/docs/extras/contributing_code]
• My PR's scope is as isolated as possible, it only solves 1 specific problem

Type

🐛 Bug Fix
🧹 Refactoring

Changes

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
litellm	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 24, 2025 11:25am