Skip to content

fix common W3C errors #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2024
Merged

fix common W3C errors #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/parts/common/breadcrumb.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
}
?>

<nav class="breadcrumb" role="navigation" aria-label="<?php esc_attr_e( 'Breadcrumb', 'beapi-frontend-framework' ); ?>">
<nav class="breadcrumb" aria-label="<?php esc_attr_e( 'Breadcrumb', 'beapi-frontend-framework' ); ?>">
<div class="container">
<?php yoast_breadcrumb( '<div class="breadcrumb__inner">', '</div>' ); ?>
</div>
Expand Down
2 changes: 1 addition & 1 deletion footer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
</main>
<footer id="footer" class="footer" role="contentinfo" aria-label="<?php esc_attr_e( 'Footer', 'beapi-frontend-framework' ); ?>">
<footer id="footer" class="footer" aria-label="<?php esc_attr_e( 'Footer', 'beapi-frontend-framework' ); ?>">

</footer>
<?php wp_footer(); ?>
Expand Down
15 changes: 7 additions & 8 deletions header.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,28 +22,27 @@ function replaceHtmlClass(regexp, str) {
</script>

<meta charset="<?php bloginfo( 'charset' ); ?>" />
<meta http-equiv="Content-Type" content="text/html; charset=<?php bloginfo( 'charset' ); ?>" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta http-equiv="x-ua-compatible" content="ie=edge">

<?php wp_head(); ?>
</head>
<body <?php body_class(); ?>>
<?php wp_body_open(); ?>
<nav class="skip-links skip-links--hidden" role="navigation" aria-label="<?php esc_attr_e( 'Fast access links', 'beapi-frontend-framework' ); ?>">
<nav class="skip-links skip-links--hidden" aria-label="<?php esc_attr_e( 'Fast access links', 'beapi-frontend-framework' ); ?>">
<ul>
<li>
<a href="#menu"><?php esc_html_e( 'Main navigation menu', 'beapi-frontend-framework' ); ?></a>
<a href="#menu"><?php esc_html_e( 'Go to main navigation menu', 'beapi-frontend-framework' ); ?></a>
</li>
<li>
<a href="#content"><?php esc_html_e( 'Main content', 'beapi-frontend-framework' ); ?></a>
<a href="#content"><?php esc_html_e( 'Go to main content', 'beapi-frontend-framework' ); ?></a>
</li>
<li>
<a href="#footer"><?php esc_html_e( 'Footer', 'beapi-frontend-framework' ); ?></a>
<a href="#footer"><?php esc_html_e( 'Go to footer', 'beapi-frontend-framework' ); ?></a>
</li>
</ul>
</nav>
<header id="header" class="header" role="banner" aria-label="<?php esc_attr_e( 'Header', 'beapi-frontend-framework' ); ?>">
<header id="header" class="header" aria-label="<?php esc_attr_e( 'Header', 'beapi-frontend-framework' ); ?>">
<div class="header__inner">
<div class="container">
<a class="header__logo-link" href="<?php echo esc_url( home_url( '/' ) ); ?>">
Expand All @@ -57,7 +56,7 @@ function replaceHtmlClass(regexp, str) {
<span class="sr-only aria-expanded-true-text"><?php esc_html_e( 'Close the menu', 'beapi-frontend-framework' ); ?></span>
</button>

<nav id="menu" class="header__menu" aria-label="<?php esc_attr_e( 'Main navigation', 'beapi-frontend-framework' ); ?>" role="navigation">
<nav id="menu" class="header__menu" aria-label="<?php esc_attr_e( 'Main navigation', 'beapi-frontend-framework' ); ?>">
<div>
<?php
wp_nav_menu(
Expand All @@ -76,7 +75,7 @@ function replaceHtmlClass(regexp, str) {
</div>
</div>
</header>
<main id="content" role="main" tabindex="-1" aria-label="<?php esc_attr_e( 'Main content', 'beapi-frontend-framework' ); ?>">
<main id="content" tabindex="-1" aria-label="<?php esc_attr_e( 'Main content', 'beapi-frontend-framework' ); ?>">
<?php
if ( ! is_front_page() && ! is_search() && ! is_404() ) {
get_template_part( 'components/parts/common/breadcrumb' );
Expand Down
103 changes: 73 additions & 30 deletions languages/beapi-frontend-framework.pot
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (C) 2022 BeAPI
# Copyright (C) 2024 BeAPI
# This file is distributed under the .
msgid ""
msgstr ""
Expand All @@ -9,56 +9,82 @@ msgstr ""
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
"POT-Creation-Date: 2022-06-30T08:09:55+00:00\n"
"POT-Creation-Date: 2024-06-28T07:38:00+00:00\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"X-Generator: WP-CLI 2.6.0\n"
"X-Generator: WP-CLI 2.10.0\n"
"X-Domain: beapi-frontend-framework\n"

#. Theme Name of the theme
#. Description of the theme
#: style.css
msgid "Be API Frontend Framework"
msgstr ""

#. Theme URI of the theme
#: style.css
msgid "https://github.com/BeAPI/beapi-frontend-framework"
msgstr ""

#. Author of the theme
#: style.css
msgid "BeAPI"
msgstr ""

#. Author URI of the theme
#: style.css
msgid "http://www.beapi.fr"
msgstr ""

#: components/blocks/footer.php:4
#: components/blocks/skip-links.php:12
#: components/parts/common/breadcrumb.php:7
msgid "Breadcrumb"
msgstr ""

#: footer.php:2
msgid "Footer"
msgstr ""

#: components/blocks/header.php:4
#: header.php:33
msgid "Fast access links"
msgstr ""

#: header.php:36
msgid "Go to main navigation menu"
msgstr ""

#: header.php:39
msgid "Go to main content"
msgstr ""

#: header.php:42
msgid "Go to footer"
msgstr ""

#: header.php:46
msgid "Header"
msgstr ""

#: components/blocks/header.php:14
msgid "Open/Close the menu"
#: header.php:56
msgid "Open the menu"
msgstr ""

#: header.php:57
msgid "Close the menu"
msgstr ""

#: components/blocks/header.php:17
#: header.php:60
msgid "Main navigation"
msgstr ""

#: components/blocks/skip-links.php:4
msgid "Fast access links"
#: header.php:79
msgid "Main content"
msgstr ""

#: components/blocks/skip-links.php:6
msgid "Main navigation menu"
#: inc/Helpers/Custom_Menu_Walker.php:27
msgid "Open menu"
msgstr ""

#: components/blocks/skip-links.php:9
#: header.php:26
msgid "Main content"
#: inc/Helpers/Custom_Menu_Walker.php:28
msgid "Close menu"
msgstr ""

#: inc/Helpers/Formatting/Link.php:144
Expand All @@ -70,61 +96,73 @@ msgid "Share on Facebook"
msgstr ""

#: inc/Helpers/Formatting/Share.php:64
msgid "Share on Twitter"
msgid "Share on X"
msgstr ""

#: inc/Helpers/Formatting/Share.php:75
msgid "Share on Linkedin"
msgstr ""

#: inc/Helpers/Formatting/Share.php:86
msgid "Share on Email"
msgid "Share on Instagram"
msgstr ""

#: inc/Helpers/Menu_Walker.php:26
msgid "Toggle menu"
#: inc/Helpers/Formatting/Share.php:97
msgid "Share on Email"
msgstr ""

#: inc/Services/Editor.php:76
#: inc/Services/Editor.php:81
msgid "Dark"
msgstr ""

#: inc/Services/Editor.php:81
#: inc/Services/Editor.php:86
msgid "Light"
msgstr ""

#: inc/Services/Editor.php:86
#: inc/Services/Editor.php:91
msgid "Primary"
msgstr ""

#: inc/Services/Editor.php:91
#: inc/Services/Editor.php:96
msgid "Secondary"
msgstr ""

#: inc/Services/Editor.php:102
#: inc/Services/Editor.php:107
msgid "Title 6"
msgstr ""

#: inc/Services/Editor.php:108
#: inc/Services/Editor.php:113
msgid "Title 5"
msgstr ""

#: inc/Services/Editor.php:114
#: inc/Services/Editor.php:119
msgid "Title 4"
msgstr ""

#: inc/Services/Editor.php:120
#: inc/Services/Editor.php:125
msgid "Title 3"
msgstr ""

#: inc/Services/Editor.php:126
#: inc/Services/Editor.php:131
msgid "Title 2"
msgstr ""

#: inc/Services/Editor.php:132
#: inc/Services/Editor.php:137
msgid "Title 1"
msgstr ""

#: inc/Services/Editor.php:251
msgid "Small"
msgstr ""

#: inc/Services/Editor.php:259
msgid "Large"
msgstr ""

#: inc/Services/Editor.php:267
msgid "Huge"
msgstr ""

#: inc/Services/Editor_Patterns.php:40
msgid "Common"
msgstr ""
Expand All @@ -151,3 +189,8 @@ msgstr ""
#: inc/Services/Menu.php:38
msgid "Footer menu"
msgstr ""

#: patterns/media-text.php
msgctxt "Pattern title"
msgid "Media Text"
msgstr ""
Binary file modified languages/fr_FR.mo
View file
Open in desktop
Binary file not shown.
Loading
Loading