Fix crash on too big files #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously CSVLint assumed that all files had length less than
int.MaxValue (2147483647), and any files longer than that would simply cause the plugin to crash.
This is OK if Notepad++ catches the crash, but if not, such a crash could cause Notepad++ to fail unexpectedly.
This commit implements a more graceful handling of too-large files, where the user is initially
notified if they try to run a plugin command on a too-large file, and they can opt out of such notifications.
Whether or not the user is notified, all plugin commands will do nothing after they detect that the file is too large.
Also reduce risk of null dereference on return value from Main.GetCurrentCsvDef, rename that function to Main.TryGetCurrentCsvDef
it was auto-inserted by Visual Studio in an earlier commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would address #93.
Previously CSVLint assumed that all files had fewer than
int.MaxValue(2147483647) bytes, and any files longer than that would simply cause the plugin to crash.This is OK (but far from ideal) if Notepad++ catches the crash, but if not, such a crash could cause Notepad++ to fail unexpectedly.
This commit implements a more graceful handling of too-large files, where the user is initially notified if they try to run a plugin command on a too-large file, and they can opt out of such notifications.
Whether or not the user is notified, all plugin commands will do nothing after they detect that the file is too large.