-
Notifications
You must be signed in to change notification settings - Fork 5
Rewrite urls with insteadOf option #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makohoek
suggested changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor remarks, but this looks good already!
0f06d80
to
034f061
Compare
makohoek
suggested changes
Jul 12, 2024
034f061
to
fecebc9
Compare
rewrite option is a wrapper to git insteadOf. First character of a URL can be replaced by something else. Signed-off-by: David Rozé <droze@baylibre.com>
Make use of rewrite option in check and _in steps. Signed-off-by: David Rozé <droze@baylibre.com>
As we add up more methods to the repo class, it becomes convenient to chain methods. This needs to return the current object in each method. Signed-off-by: David Rozé <droze@baylibre.com>
Signed-off-by: David Rozé <droze@baylibre.com>
Rewrite fake url to correct url with rewrite option to make sure it's effective Signed-off-by: David Rozé <droze@baylibre.com>
rewrite option usage example Signed-off-by: David Rozé <droze@baylibre.com>
fecebc9
to
101559e
Compare
makohoek
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The insteadOf option gives the ability to easily rewrite git protocols or even urls.
It can be useful to pull repositories from a mirror.