Skip to content

Add Graphite support #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mchro
Copy link
Contributor

@mchro mchro commented Nov 15, 2019

Using the Graphite plaintext protocol: https://graphite.readthedocs.io/en/latest/feeding-carbon.html

I chosed some specific datapoints to grab out, to not send a lot of redundant data.

@daromer2
Copy link
Collaborator

Your code is static. It should be based on the message files and generic like sendinflux and mqtt is.

@mchro
Copy link
Contributor Author

mchro commented Nov 15, 2019

I think it makes little sense to blindly copy all the fields from the messages to Graphite. In Graphite every datapoint becomes a series (pre-allocated, etc.). Graphite has builtin support for a lot of data manipulation, so it e.g. does not make sense to store averages, minimum, or maximum, if the data points are available for calculating them.

I could hide selection of fields behind a config flag, so the option of doing the generic storing is there?

@daromer2
Copy link
Collaborator

daromer2 commented Mar 7, 2021

The thing is the "case" that is extra in the code. To have this code as generic as possible to handle all scenarios i would like to skip them as far as we can. I know that graphite can work with the data and same does Influx. Not all messages from Batrium suit those databases since you get tons of em :)

@mchro mchro force-pushed the graphite-support branch from afdae13 to fee7ec4 Compare March 11, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants