Skip to content

[geolocator_apple]: Bump flutter_lints from 4.0.0 to 5.0.0 in /geolocator_apple #1582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
98b3d98
[geolocator_apple]: Bump flutter_lints in /geolocator_apple
dependabot[bot] Sep 30, 2024
eb5bf71
Fixes a bug where iOS location settings, e.g. `accuracy` and `distanc…
ksenia-lyagusha Nov 14, 2024
8060651
Changed geolocator to 13.0.2 which updates dependency on geolocator_a…
ksenia-lyagusha Nov 14, 2024
ad525fe
Migrates away from Android imperative gradle api
mvanbeusekom Nov 14, 2024
f3f4ea8
Adds back the stopListening method
mvanbeusekom Nov 14, 2024
e3bc4d4
adds privacy manifest to MacOS (#1636)
TimHoogstrate Feb 12, 2025
5316740
Android updates (#1641)
TimHoogstrate Mar 4, 2025
c08b6ca
updates Apple package (#1642)
TimHoogstrate Mar 4, 2025
4431151
Updates linux project (#1643)
TimHoogstrate Mar 6, 2025
29fc15d
Updates windows project (#1644)
TimHoogstrate Mar 6, 2025
83de9fc
updates web package (#1645)
TimHoogstrate Mar 7, 2025
4a193c6
Adds macOS privacy manifest to the podspec (#1660)
TimHoogstrate Mar 17, 2025
60ba98c
Remove < iOS 11 fallback API calls in openSettings: (#1653)
jmagman Mar 17, 2025
582874e
updated version number in pubspec (#1661)
TimHoogstrate Mar 17, 2025
d37e6c2
update platform interface package (#1647)
TimHoogstrate Mar 17, 2025
40acbc2
Fix android deprecation warnings (#1648)
TimHoogstrate Mar 18, 2025
b58d657
Updates AFP (#1646)
TimHoogstrate Mar 18, 2025
a4934dc
[iOS]update isMocked documentation (#1370)
TimHoogstrate Mar 20, 2025
462f362
[geolocator_apple] Add swift package manager compatibility (#1630)
alejandro-all-win-software Mar 21, 2025
3076966
[geolocator_linux]: Bump flutter_lints in /geolocator_linux/example (…
dependabot[bot] Mar 24, 2025
ac3a203
added changelog for flutter_lints bump for geolocator_linux (#1674)
TimHoogstrate Mar 25, 2025
0cc31c1
[geolocator_android]: Bump flutter_lints in /geolocator_android/examp…
dependabot[bot] Mar 25, 2025
168e47f
bump version flutter lints for geolocator_android (#1675)
TimHoogstrate Mar 25, 2025
9833077
[geolocator_windows]: Bump flutter_lints in /geolocator_windows/examp…
dependabot[bot] Mar 25, 2025
56bb76b
Bump windows version (#1676)
TimHoogstrate Mar 25, 2025
30e30a1
[geolocator]: Bump flutter_lints in /geolocator/example (#1668)
dependabot[bot] Mar 27, 2025
c891e41
[geolocator_web]: Bump flutter_lints in /geolocator_web/example (#1667)
dependabot[bot] Mar 27, 2025
03c0c74
update geolocator afp and gelocator web changelog and bump version. (…
TimHoogstrate Mar 31, 2025
a77a67f
Updated version number and changelog
TimHoogstrate Apr 1, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/geolocator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@ jobs:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v4

# Ensures JAVA 11 is installed on the build agent.
# Ensures JAVA 17 is installed on the build agent.
- uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'

# Make sure the stable version of Flutter is available
- uses: subosito/flutter-action@v2
Expand All @@ -49,8 +49,8 @@ jobs:
run: flutter pub get
working-directory: ${{env.source-directory}}

# Run Flutter Format to ensure formatting is valid
- name: Run Flutter Format
# Run Dart Format to ensure formatting is valid
- name: Run Dart Format
run: dart format --set-exit-if-changed .
working-directory: ${{env.source-directory}}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/geolocator_android.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'

# Make sure the stable version of Flutter is available
- uses: subosito/flutter-action@v2
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ unlinked.ds
unlinked_spec.ds
flutter_export_environment.sh
**/.flutter-plugins-dependencies
**/Flutter/ephemeral/

# Android related
gradle-wrapper.jar
Expand Down Expand Up @@ -95,6 +96,8 @@ GeneratedPluginRegistrant.java
**/ios/ServiceDefinitions.json
**/ios/Runner/GeneratedPluginRegistrant.*
**/ios/Flutter/Flutter.podspec
**/.build/
**/.swiftpm/

# Firebase related
.firebase/
Expand Down
14 changes: 14 additions & 0 deletions geolocator/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
## 13.0.4

- Bump `flutter_lints` to version 5.0.0

## 13.0.3

- Updates dart sdk to `sdk: ^3.5.0`
- Updates example project and fixes analyzer issues

## 13.0.2

- Updates dependency on geolocator_apple to version 2.3.8.
- Migrates Android configuration of example app away from imperative gradle API.

## 13.0.1

- Resolves problems when compiling non-web platforms because of illegal reference to `dart:js_interop`.
Expand Down
4 changes: 2 additions & 2 deletions geolocator/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ The TL;DR version is:
android.useAndroidX=true
android.enableJetifier=true
```
2. Make sure you set the `compileSdkVersion` in your "android/app/build.gradle" file to 34:
2. Make sure you set the `compileSdkVersion` in your "android/app/build.gradle" file to 35:

```
android {
compileSdkVersion 34
compileSdkVersion 35

...
}
Expand Down
19 changes: 8 additions & 11 deletions geolocator/example/android/app/build.gradle
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
plugins {
id "com.android.application"
id "dev.flutter.flutter-gradle-plugin"
}

def localProperties = new Properties()
def localPropertiesFile = rootProject.file('local.properties')
if (localPropertiesFile.exists()) {
Expand All @@ -6,11 +11,6 @@ if (localPropertiesFile.exists()) {
}
}

def flutterRoot = localProperties.getProperty('flutter.sdk')
if (flutterRoot == null) {
throw new GradleException("Flutter SDK not found. Define location with flutter.sdk in the local.properties file.")
}

def flutterVersionCode = localProperties.getProperty('flutter.versionCode')
if (flutterVersionCode == null) {
flutterVersionCode = '1'
Expand All @@ -27,18 +27,15 @@ project.getTasks().withType(JavaCompile) {
options.compilerArgs.addAll(args)
}

apply plugin: 'com.android.application'
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"

android {
compileSdkVersion 33
compileSdkVersion flutter.compileSdkVersion


defaultConfig {
// TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
applicationId "com.baseflow.geolocator_example"
minSdkVersion 16
targetSdkVersion 30
minSdkVersion flutter.minSdkVersion
targetSdkVersion flutter.targetSdkVersion
versionCode flutterVersionCode.toInteger()
versionName flutterVersionName
}
Expand Down
3 changes: 2 additions & 1 deletion geolocator/example/android/app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
android:theme="@style/LaunchTheme"
android:configChanges="orientation|keyboardHidden|keyboard|screenSize|smallestScreenSize|locale|layoutDirection|fontScale|screenLayout|density|uiMode"
android:hardwareAccelerated="true"
android:windowSoftInputMode="adjustResize">
android:windowSoftInputMode="adjustResize"
android:exported="true">
<!-- Specifies an Android theme to apply to this Activity as soon as
the Android process has started. This theme is visible to the user
while the Flutter UI initializes. After that, this theme continues
Expand Down
13 changes: 1 addition & 12 deletions geolocator/example/android/build.gradle
Original file line number Diff line number Diff line change
@@ -1,14 +1,3 @@
buildscript {
repositories {
google()
mavenCentral()
}

dependencies {
classpath 'com.android.tools.build:gradle:7.1.2'
}
}

allprojects {
repositories {
google()
Expand All @@ -24,6 +13,6 @@ subprojects {
project.evaluationDependsOn(':app')
}

task clean(type: Delete) {
tasks.register("clean", Delete) {
delete rootProject.buildDir
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.2-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.9-all.zip
29 changes: 19 additions & 10 deletions geolocator/example/android/settings.gradle
Original file line number Diff line number Diff line change
@@ -1,15 +1,24 @@
include ':app'
pluginManagement {
def flutterSdkPath = {
def properties = new Properties()
file("local.properties").withInputStream { properties.load(it) }
def flutterSdkPath = properties.getProperty("flutter.sdk")
assert flutterSdkPath != null, "flutter.sdk not set in local.properties"
return flutterSdkPath
}()

def flutterProjectRoot = rootProject.projectDir.parentFile.toPath()
includeBuild("$flutterSdkPath/packages/flutter_tools/gradle")

def plugins = new Properties()
def pluginsFile = new File(flutterProjectRoot.toFile(), '.flutter-plugins')
if (pluginsFile.exists()) {
pluginsFile.withReader('UTF-8') { reader -> plugins.load(reader) }
repositories {
google()
mavenCentral()
gradlePluginPortal()
}
}

plugins.each { name, path ->
def pluginDirectory = flutterProjectRoot.resolve(path).resolve('android').toFile()
include ":$name"
project(":$name").projectDir = pluginDirectory
plugins {
id "dev.flutter.flutter-plugin-loader" version "1.0.0"
id "com.android.application" version "8.7.0" apply false
}

include ":app"
2 changes: 1 addition & 1 deletion geolocator/example/ios/Flutter/AppFrameworkInfo.plist
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@
<key>CFBundleVersion</key>
<string>1.0</string>
<key>MinimumOSVersion</key>
<string>8.0</string>
<string>11.0</string>
</dict>
</plist>
9 changes: 6 additions & 3 deletions geolocator/example/ios/Runner.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
MTL_ENABLE_DEBUG_INFO = NO;
SDKROOT = iphoneos;
SUPPORTED_PLATFORMS = iphoneos;
Expand All @@ -353,6 +353,7 @@
"$(PROJECT_DIR)/Flutter",
);
INFOPLIST_FILE = Runner/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
Expand Down Expand Up @@ -414,7 +415,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
MTL_ENABLE_DEBUG_INFO = YES;
ONLY_ACTIVE_ARCH = YES;
SDKROOT = iphoneos;
Expand Down Expand Up @@ -463,7 +464,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
MTL_ENABLE_DEBUG_INFO = NO;
SDKROOT = iphoneos;
SUPPORTED_PLATFORMS = iphoneos;
Expand All @@ -485,6 +486,7 @@
"$(PROJECT_DIR)/Flutter",
);
INFOPLIST_FILE = Runner/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
Expand All @@ -511,6 +513,7 @@
"$(PROJECT_DIR)/Flutter",
);
INFOPLIST_FILE = Runner/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
Expand Down
2 changes: 1 addition & 1 deletion geolocator/example/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ void main() {
/// Example [Widget] showing the functionalities of the geolocator plugin
class GeolocatorWidget extends StatefulWidget {
/// Creates a new GeolocatorWidget.
const GeolocatorWidget({Key? key}) : super(key: key);
const GeolocatorWidget({super.key});

/// Utility method to create a page with the Baseflow templating.
static ExamplePage createPage() {
Expand Down
4 changes: 2 additions & 2 deletions geolocator/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ description: Demonstrates how to use the geolocator plugin.
publish_to: 'none' # Remove this line if you wish to publish to pub.dev

environment:
sdk: ">=2.15.0 <3.0.0"
sdk: ^3.5.0

dependencies:
baseflow_plugin_template: ^2.1.2
Expand All @@ -33,7 +33,7 @@ dependencies:
dev_dependencies:
flutter_test:
sdk: flutter
flutter_lints: ^3.0.1
flutter_lints: ^5.0.0

# For information on the generic Dart part of this file, see the
# following page: https://dart.dev/tools/pub/pubspec
Expand Down
6 changes: 3 additions & 3 deletions geolocator/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ name: geolocator
description: Geolocation plugin for Flutter. This plugin provides a cross-platform (iOS, Android) API for generic location (GPS etc.) functions.
repository: https://github.com/baseflow/flutter-geolocator/tree/main/geolocator
issue_tracker: https://github.com/baseflow/flutter-geolocator/issues?q=is%3Aissue+is%3Aopen
version: 13.0.1
version: 13.0.4

environment:
sdk: ">=2.15.0 <4.0.0"
sdk: ^3.5.0
flutter: ">=2.8.0"

flutter:
Expand All @@ -28,7 +28,7 @@ dependencies:

geolocator_platform_interface: ^4.2.3
geolocator_android: ^4.6.0
geolocator_apple: ^2.3.7
geolocator_apple: ^2.3.8
geolocator_web: ^4.1.1
geolocator_windows: ^0.2.3

Expand Down
16 changes: 16 additions & 0 deletions geolocator_android/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
## 5.0.1

- Bump `flutter_lints` to version 5.0.0

## 5.0.0

- **BREAKING CHANGE:** for Flutter `3.27.0` and below. Make sure you'll upgrade Flutter to `3.29.0` or above before using this version.
* Fixes deprecation warnings

## 4.6.2

* Updates compileSDKVersion to 35
* Updates Fixed warnings in Android package and Android example project
* Updates gradle version
* Updates com.android.application version to 8.7.0

## 4.6.1

* Fixes a bug where the plugin throws an exception while requesting locations updates with coarse location permission only.
Expand Down
6 changes: 3 additions & 3 deletions geolocator_android/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:7.4.2'
classpath 'com.android.tools.build:gradle:8.0.2'
}
}

Expand All @@ -26,10 +26,10 @@ android {
namespace("com.baseflow.geolocator")
}

compileSdk 34
compileSdk flutter.compileSdkVersion

defaultConfig {
minSdkVersion 16
minSdkVersion flutter.minSdkVersion
}
lintOptions {
disable 'InvalidPackage'
Expand Down
4 changes: 2 additions & 2 deletions geolocator_android/example/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ android {
compileSdkVersion flutter.compileSdkVersion

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
}

lintOptions {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-bin.zip

2 changes: 1 addition & 1 deletion geolocator_android/example/android/settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ pluginManagement {

plugins {
id "dev.flutter.flutter-plugin-loader" version "1.0.0"
id "com.android.application" version "7.4.2" apply false
id "com.android.application" version "8.7.0" apply false
}

include ":app"
Loading