BN-49. Lab investigation order requests shouldn't be getting duplicated when a user places an order and subsequently removes ordered requests. #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when a user places an order and subsequently removes ordered requests.
mohan-13
requested changes
Jun 10, 2025
src/constants/app.ts
Outdated
| export const PATIENT_LAB_INVESTIGATION_RESOURCE_URL = (patientUUID: string) => | ||
| OPENMRS_FHIR_R4 + | ||
| `/ServiceRequest?category=${LAB_ORDER_TYPE_UUID}&patient=${patientUUID}&numberOfVisits=5`; | ||
| `/ServiceRequest?category=${LAB_ORDER_TYPE_UUID}&patient=${patientUUID}&numberOfVisits=5&_count=100`; |
There was a problem hiding this comment.
add the sort parameter as well
rahu1ramesh
requested changes
Jun 10, 2025
There was a problem hiding this comment.
I feel
FhirLabTestBundlecould potentially be replaced with the standardBundletype fromfhir/r4FhirLabTestcould potentially be replaced with the standardServiceRequesttype fromfhir/r4
Using standard FHIR R4 types (like ServiceRequest) ensures architectural consistency, reduces maintenance, improves type safety, enhances interoperability, and delivers better tooling, clarity, and long-term support.
…type and FhirLabTest with ServiceRequest from fhir/r4
…instead of custom interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA → BN-49
Description
This PR is to resolve the issue raised after QA where it was observed that lab investigation order requests are getting duplicated when a user places an order and subsequently removes ordered requests.