COMP: Override cmake minimum policy version. #546

hjmjohnson · 2025-10-21T13:58:05Z

See the CONTRIBUTING guide. Specifically:

Start BRAINSTools commit messages with a standard prefix (and a space):

BUG: fix for runtime crash or incorrect result
COMP: compiler error or warning fix
DOC: documentation change
ENH: new functionality
PERF: performance improvement
STYLE: no logic impact (indentation, comments)
WIP: Work In Progress not ready for merge

Provide a short, meaningful message that describes the change you made.

When the Pull Request (PR) is based on a single commit, the commit message is usually left as the PR message.

A reference to a related issue or pull request in your repository. You can automatically close a related issues using keywords

@mentions of the person or team responsible for reviewing proposed changes.

Thanks for contributing to BRAINSTools!

Be in sync with Slicer and ITK cmake minimums.

Remove dead code that has been commented out 10yrs

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

…tion See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

…gn-macro See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

…ray-index See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

…ault-by-value See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

SetDesiredDirectionCosines(orient.GetAsDirection()) with UseImageDirectionOff() to bypass the legacy enum entirely.

hjmjohnson force-pushed the update-cmake-4-build branch from 947472d to b566868 Compare November 9, 2025 17:07

hjmjohnson added 29 commits November 9, 2025 17:55

ENH: Change cmake support ranges

b8d6e81

Be in sync with Slicer and ITK cmake minimums.

ENH: Update VTK to 9.5

116da1f

COMP: Update ITKv5 Git tag to release-5.4

7e4d062

STYLE: Remove commented out code from 2016.

c08d5b0

Remove dead code that has been commented out 10yrs

COMP: Fix missing shebang chmod mismatch

c15bdd4

ENH: Adding precommit and .clang-format sync with ITK.

ce1690c

ENH: Add initial .clang-tidy file for BRAINSTools

a702247

STYLE: Apply clang-tidy rule performance-unnecessary-value-param

7619ec3

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule performance-enum-size

7abb39f

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule performance-faster-string-find

7b1ee4b

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule performance-for-range-copy

e7f415c

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule performance-implicit-conversion-in-loop

ff77dd0

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule performance-inefficient-algorithm

bf151bd

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule performance-inefficient-string-concatena…

8ef3d32

…tion See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule performance-inefficient-vector-operation

02fd9f1

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule performance-move-const-arg

33a4807

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule performance-noexcept-destructor

61589d5

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule performance-noexcept-move-constructor

925b71f

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule performance-noexcept-swap

051e651

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule performance-trivially-destructible

3f9e0ee

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule performance-type-promotion-in-math-fn

c33cdd5

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule performance-unnecessary-copy-initialization

57b7a7f

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule modernize-deprecated-headers

117db66

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule modernize-pass-by-value

a239f22

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule modernize-return-braced-init-list

20b9b29

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule modernize-type-traits

b08c725

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule modernize-use-bool-literals

10a8134

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule modernize-use-nullptr

3ee9c88

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule modernize-use-using

89b8862

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

hjmjohnson added 29 commits November 9, 2025 17:55

STYLE: Apply clang-tidy rule modernize-raw-string-literal

7f79394

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule modernize-redundant-void-arg

5a54776

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule modernize-replace-auto-ptr

ee54f26

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule modernize-replace-disallow-copy-and-assi…

dc085f4

…gn-macro See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule modernize-replace-random-shuffle

1765b5f

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule modernize-shrink-to-fit

e7e3a74

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule modernize-unary-static-assert

7e9cbb1

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule modernize-use-constraints

83deb7c

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule modernize-use-default-member-init

b88afa1

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule modernize-use-designated-initializers

3b2ae44

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule modernize-use-emplace

345f00e

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule modernize-use-integer-sign-comparison

00e1f90

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule modernize-use-ranges

a421cdd

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule modernize-use-starts-ends-with

963311d

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule modernize-use-std-format

e90e6a8

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule modernize-use-std-numbers

569417d

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule modernize-use-std-print

ce15855

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule modernize-use-uncaught-exceptions

d77ef58

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule modernize-avoid-c-arrays

23002b9

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule bugprone-incorrect-roundings

6873a4a

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule cppcoreguidelines-init-variables

fcb7b39

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule cppcoreguidelines-prefer-member-initializer

1495b22

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule cppcoreguidelines-pro-bounds-constant-ar…

a254a80

…ray-index See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule cppcoreguidelines-misleading-capture-def…

e2b07d3

…ault-by-value See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule readability-container-size-empty

5bdbdcd

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

STYLE: Apply clang-tidy rule readability-make-member-function-const

5928ee2

See: https://clang.llvm.org/extra/clang-tidy/checks/list.html

COMP: Prevent clang-tidy over-constification.

69832eb

STYLE: Remove unused type aliases to improve code readability

318b19a

COMP: Update coordinate orientation mechanism in itkIO.h

0f84e1a

SetDesiredDirectionCosines(orient.GetAsDirection()) with UseImageDirectionOff() to bypass the legacy enum entirely.

hjmjohnson force-pushed the update-cmake-4-build branch from b566868 to 0f84e1a Compare November 9, 2025 23:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

COMP: Override cmake minimum policy version. #546

COMP: Override cmake minimum policy version. #546

hjmjohnson commented Oct 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

COMP: Override cmake minimum policy version. #546

Are you sure you want to change the base?

COMP: Override cmake minimum policy version. #546

Conversation

hjmjohnson commented Oct 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants