Skip to content

Removed the avg tx proof duration column due to technical issues #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2024
Merged

Removed the avg tx proof duration column due to technical issues #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions coordinator/src/benchmarking.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@ pub struct BenchmarkingStats {
/// from this block and all blocks beforehand. None implies data not
/// available, not 0.
pub cumulative_n_txs: Option<u64>,
/// The average duration to prove a singular transaction. If there are no
/// transactions, the value should be None. Otherwise, we should see the
/// number of transactions divided by the total duration.
pub avg_tx_proof_duration: Option<f64>,
/// The duration fo time took to fetch [prover::ProverInput], stored as a
/// [Duration].
pub fetch_duration: Duration,
Expand Down Expand Up @@ -65,7 +61,7 @@ impl BenchmarkingStats {
/// Returns a header row
pub fn header_row() -> String {
String::from(
"block_number, number_txs, cumulative_number_txs, avg_tx_proof_duration, fetch_duration, proof_duration, start_time, end_time, overall_elapsed_time, proof_out_duration, gas_used, gas_used_per_tx, cumulative_gas_used, difficulty",
"block_number, number_txs, cumulative_number_txs, fetch_duration, proof_duration, start_time, end_time, overall_elapsed_time, proof_out_duration, gas_used, gas_used_per_tx, cumulative_gas_used, difficulty",
)
}

Expand Down Expand Up @@ -102,11 +98,10 @@ impl BenchmarkingStats {
#[allow(clippy::format_in_format_args)]
pub fn as_csv_row(&self) -> String {
format!(
"{}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {}, \"{}\", {}, {}",
"{}, {}, {}, {}, {}, {}, {}, {}, {}, {}, \"{}\", {}, {}",
self.block_number,
self.n_txs,
Self::unwrap_to_string(self.cumulative_n_txs),
Self::unwrap_to_string(self.avg_tx_proof_duration),
self.fetch_duration.as_secs_f64(),
self.proof_duration.as_secs_f64(),
self.start_time.format("%d-%m-%Y %H:%M:%S"),
Expand Down
8 changes: 0 additions & 8 deletions coordinator/src/manyprover.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,10 +330,6 @@ impl ManyProver {
block_number: block_num,
n_txs: n_txs as u64,
cumulative_n_txs: None,
avg_tx_proof_duration: match n_txs {
0 => None,
n_txs => Some(n_txs as f64 / proof_duration.as_secs_f64()),
},
fetch_duration,
proof_duration,
start_time: proof_start_stamp,
Expand Down Expand Up @@ -855,10 +851,6 @@ impl ManyProver {
block_number: cur_block_num,
n_txs,
cumulative_n_txs: Some(cumulative_n_txs),
avg_tx_proof_duration: match n_txs {
0 => None,
n_txs => Some(n_txs as f64 / proof_duration.as_secs_f64()),
},
fetch_duration,
proof_duration,
start_time: proof_start_stamp,
Expand Down