[azure-http-specs] ARM, fix extension resource case #3424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: XiaofeiCao <92354331+XiaofeiCao@users.noreply.github.com>
Co-authored-by: XiaofeiCao <92354331+XiaofeiCao@users.noreply.github.com>
Co-authored-by: XiaofeiCao <92354331+XiaofeiCao@users.noreply.github.com>
Co-authored-by: XiaofeiCao <92354331+XiaofeiCao@users.noreply.github.com>
commit: |
|
All changed packages have been documented.
|
|
You can try these changes here
|
XiaofeiCao
requested review from
bterlson,
iscai-msft,
jhendrixMSFT,
joheredi,
lmazuel,
m-nash,
markcowl,
srnagar,
tadelesh,
timotheeguerin and
weidongxu-microsoft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with ARM extension resource test cases by simplifying the mock API implementation. The change removes complex helper functions and duplicate test entries, replacing them with direct URI definitions for cleaner and more maintainable test scenarios.
Key Changes:
- Removed helper functions (
getServiceKey,requestHandler,getUri) and thewithServiceKeyspattern - Eliminated duplicate test entries for various scope URIs (with and without leading slashes)
- Simplified test definitions by using
passOnSuccessdirectly with inline URIs
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/azure-http-specs/specs/azure/resource-manager/resources/mockapi.ts | Refactored extension resource mock API by removing helper functions and duplicate entries, replacing with direct URI definitions for GET, PUT, PATCH, DELETE and list operations |
| .chronus/changes/fix-arm-extension-resource-2025-10-20-07-15-02.md | Added changelog entry documenting the bug fix for ARM ExtensionResource test case |
weidongxu-microsoft
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
passOnSuccessinstead ofwithServiceKeys#3412