-
Notifications
You must be signed in to change notification settings - Fork 65
[TCGC] Add External usage flag for types referenced by external types #3422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: tadelesh <1726438+tadelesh@users.noreply.github.com>
…lag propagation Co-authored-by: tadelesh <1726438+tadelesh@users.noreply.github.com>
…l sites Co-authored-by: tadelesh <1726438+tadelesh@users.noreply.github.com>
…l types themselves Co-authored-by: tadelesh <1726438+tadelesh@users.noreply.github.com>
@copilot do not update external usage everywhere, do it after update spread usage. |
…usage Co-authored-by: tadelesh <1726438+tadelesh@users.noreply.github.com>
Consolidated all External usage updates into a single |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/typespec-client-generator-core/test/decorators/alternate-type.test.ts
Outdated
Show resolved
Hide resolved
packages/typespec-client-generator-core/test/decorators/alternate-type.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: tadelesh <1726438+tadelesh@users.noreply.github.com>
commit: |
@copilot format the code |
Co-authored-by: tadelesh <1726438+tadelesh@users.noreply.github.com>
Code formatted with prettier. (commit ab3c9d1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need more discussion.
Update: current design may meet issue for scenario that shared model across external type and normal type. But That scenario may not appear so let us go on.
External
flag toUsageFlags
enum in interfaces.ts✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.