Skip to content

refactor(staleGet): refactor staleGet to randomize target endpoint #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

refactor(staleGet): refactor staleGet to randomize target endpoint #213

wants to merge 5 commits into from

Conversation

vittoriasalim
Copy link
Contributor

@vittoriasalim vittoriasalim commented Sep 4, 2025 •
edited
Loading

  • randomize get to randomize target endpoint, so we can have a more realistic workload
  • add get into latency aggregation, this is to aggregate the latency of all target endpoints

wonderyl
wonderyl reviewed Sep 11, 2025
View reviewed changes
request/requester.go
// Aggregates for DELETE and PATCH methods, replaces the last path segment
// for DELETE and PATCH requests so they can be aggregated (e.g. in metrics)
if reqr.method == http.MethodDelete || reqr.method == http.MethodPatch {
// Aggregates for DELETE, PATCH, and GET methods, replaces the last path segment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the comment in either line 42 or line 46 and only keep one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xinWeiWei24 xinWeiWei24 Awaiting requested review from xinWeiWei24

@fuweid fuweid Awaiting requested review from fuweid

1 more reviewer

@wonderyl wonderyl wonderyl left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vittoriasalim @wonderyl