Refactor: extract rollingUpdateFn for batching and customization #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted rollingUpdateFn() from DeployAndRepeatRollingUpdateDeployments() to enable future support for batching deployments and customizing the number of deployments to roll out.
wonderyl
reviewed
Jun 18, 2025
wonderyl
approved these changes
Jun 19, 2025
fuweid
approved these changes
Jul 11, 2025
| for i := 0; i < total; i++ { | ||
| name := fmt.Sprintf("%s-%d", namePattern, i) | ||
| ns := name | ||
| func RollingUpdateDeployments(ctx context.Context, total int, namePattern string, kubeCfgPath string, internal time.Duration) { |
There was a problem hiding this comment.
not blocker: you can help it in the follow-up
func RollingUpdateDeployments(ctx context.Context, kubeCfgPath string, namePattern string, total int, internal time.Duration)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted rollingUpdateFn() from DeployAndRepeatRollingUpdateDeployments() to enable future support for batching deployments and customizing the number of deployments to roll out.