*: update ResponseError type #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fuweid
commented
Dec 18, 2024
fuweid
commented
- Show Code/Message so that it's easy to generate database schema
- Add URL in error
* Show Code/Message so that it's easy to generate database schema * Add URL in error Signed-off-by: Wei Fu <weifu@microsoft.com>
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
api/types/metric.go:34
- Changing the
Codefield from optional (omitempty) to mandatory could lead to issues if there are scenarios where this field is not always populated. Consider keeping it optional.
Code int `json:"code"`
api/types/metric.go:38
- Changing the
Messagefield from optional (omitempty) to mandatory could lead to issues if there are scenarios where this field is not always populated. Consider keeping it optional.
Message string `json:"message"`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.