Skip to content

Make native-tls dependency optional for azure_messaging_eventhubs #2797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make native-tls dependency optional for azure_messaging_eventhubs #2797

wants to merge 1 commit into from

Conversation

georgeh0
Copy link

resolves #2796

@github-actions github-actions bot added Azure.Core The azure_core crate Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Jul 16, 2025
@github-actions GitHub Actions
Copy link

Thank you for your contribution @georgeh0! We will review the pull request and get back to you soon.

@georgeh0
Copy link
Author

@microsoft-github-policy-service agree company="CocoIndex"

@LarryOsterman
Copy link
Member

Your change looks fine to me, but unfortunately our component governance system is complaining about the "ring" dependency that gets introduced with the rustls dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heaths heaths Awaiting requested review from heaths heaths is a code owner

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

@LarryOsterman LarryOsterman Awaiting requested review from LarryOsterman LarryOsterman is a code owner

@ronniegeraghty ronniegeraghty Awaiting requested review from ronniegeraghty ronniegeraghty is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Azure.Core The azure_core crate Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

azure_messaging_eventhubs should allow users to use rustls instead of native-tls
2 participants
@georgeh0 @LarryOsterman