-
Notifications
You must be signed in to change notification settings - Fork 295
typespec_client_core: New web_runtime
to support wasm32-unknown-unknown
#2770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
magodo
wants to merge
11
commits into
main
Choose a base branch
from
wasm_sleep
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2ab872d
typespec_client_core: Use `gloo_timers::future::sleep` to impl `sleep…
magodo c92b92b
fix warning
magodo 5b5607b
dont unwrap
magodo 6fa709a
clean up cargo.toml
magodo 411faaf
pass build
magodo 6069a4f
Define a web_runtime instead of conditionally implement sleep
magodo 55ce372
minor
magodo 23692dc
clippy
magodo 019ef31
improve `spawn`
magodo 5ecd47f
correct error handling
magodo 349b3c3
introduce feature wasm-bindgen
magodo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
sdk/typespec/typespec_client_core/src/async_runtime/web_runtime.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
// Copyright (c) Microsoft Corporation. All rights reserved. | ||
// Licensed under the MIT License. | ||
|
||
use super::{AsyncRuntime, SpawnedTask, TaskFuture}; | ||
use crate::time::Duration; | ||
use futures::channel::oneshot; | ||
|
||
/// An [`AsyncRuntime`] using `tokio` based APIs. | ||
pub(crate) struct WasmBindgenRuntime; | ||
|
||
impl AsyncRuntime for WasmBindgenRuntime { | ||
fn spawn(&self, f: TaskFuture) -> SpawnedTask { | ||
let (tx, rx) = oneshot::channel(); | ||
|
||
wasm_bindgen_futures::spawn_local(async move { | ||
let result = f.await; | ||
let _ = tx.send(result); | ||
}); | ||
|
||
Box::pin(async { | ||
rx.await | ||
.map_err(|e| Box::new(e) as Box<dyn std::error::Error>) | ||
}) | ||
} | ||
|
||
fn sleep(&self, duration: Duration) -> TaskFuture { | ||
Box::pin(async move { | ||
if let Ok(d) = duration.try_into() { | ||
gloo_timers::future::sleep(d).await; | ||
heaths marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} else { | ||
// This means the duration is negative, don't sleep at all. | ||
return; | ||
} | ||
}) | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems this line is no longer needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to do #2770 (comment), this is still needed to allow a user to select the
StdRuntime
even target to wasm32.