Distributed Tracing integration with SDK builds. #2741
+5,685
−263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LarryOsterman
force-pushed
the
larryo/opentelemetry_prototype_implementation
branch
from
32c2ac1 to
baccb1b
Compare
lmolkova
reviewed
Jul 1, 2025
sdk/core/azure_core/src/http/policies/request_instrumentation.rs
Outdated
Show resolved
Hide resolved
lmolkova
reviewed
Jul 1, 2025
sdk/core/azure_core/src/http/policies/request_instrumentation.rs
Outdated
Show resolved
Hide resolved
lmolkova
reviewed
Jul 1, 2025
sdk/core/azure_core/src/http/policies/request_instrumentation.rs
Outdated
Show resolved
Hide resolved
lmolkova
approved these changes
Jul 1, 2025
sdk/core/azure_core/src/http/policies/request_instrumentation.rs
Outdated
Show resolved
Hide resolved
sdk/core/azure_core/src/http/policies/request_instrumentation.rs
Outdated
Show resolved
Hide resolved
sdk/core/azure_core/src/http/policies/request_instrumentation.rs
Outdated
Show resolved
Hide resolved
sdk/core/azure_core/src/http/policies/request_instrumentation.rs
Outdated
Show resolved
Hide resolved
|
@heaths @lmolkova @analogrelay @RickWinter At this point, I think I'm done with this PR, let me know what you think about it. |
analogrelay
reviewed
Jul 17, 2025
There was a problem hiding this comment.
Still working my way through most of azure_core_opentelemetry but wrapping up my day and wanted to get some of the comments out there. Almost entirely style/idiom stuff, with a few other thoughts on the proc macro and attribute key storage. Looking good! I like the proc macros!
sdk/core/azure_core/src/http/policies/instrumentation/public_api_instrumentation.rs
Outdated
Show resolved
Hide resolved
sdk/core/azure_core/src/http/policies/instrumentation/public_api_instrumentation.rs
Outdated
Show resolved
Hide resolved
lmolkova
reviewed
Jul 21, 2025
sdk/core/azure_core/src/http/policies/instrumentation/public_api_instrumentation.rs
Outdated
Show resolved
Hide resolved
sdk/core/azure_core/src/http/policies/instrumentation/request_instrumentation.rs
Outdated
Show resolved
Hide resolved
sdk/core/azure_core/src/http/policies/instrumentation/request_instrumentation.rs
Outdated
Show resolved
Hide resolved
sdk/core/azure_core/src/http/policies/instrumentation/request_instrumentation.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
…://github.com/LarryOsterman/azure-sdk-for-rust into larryo/opentelemetry_prototype_implementation
…ve test reliability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added distributed tracing policy and example service client integration.
PR Changes:
RequestInstrumentationPolicyto add spans for HTTP operations.PublicApiInstrumentationPolicyto add spans for public APIs.PublicApiInstrumentationInformationwhich expresses information used to create Public API spans.RequestInstrumentationPolicyandPublicApiInstrumentationPolicytoazure_corepipeline creation.azure_core::ClientOptions::deconstruct()method to deconstruct to atypespec_client_core::ClientOptionsand aazure_core::CoreClientOptions(which is crate-private).http::Method::as_str()to return a string slice with the name of the HTTP method.Span::add_event, removedAttributeValue::U64and replaced it withAttributeValue::F64),Bug fix: Propagate retry policy options from client options to retry policy.