Update azure-healthinsights-radiologyinsights SDK from local TypeSpec #41949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated SDK using local TypeSpec spec from C:\Users\caperal\repos\azure-rest-api-specs\specification\ai\HealthInsights\HealthInsights.RadiologyInsights - Added new custom inference functionality with begin_custom_inference method - Fixed import-error pylint warnings for collections.abc.MutableMapping imports - Fixed no-value-for-parameter pylint warning in model_base.py - Updated client operations mixin class names to follow new naming convention - Fixed setup.py package folder path resolution - All static validation (Pylint, MyPy, Pyright, Sphinx) now passes successfully
|
@tomsft @koen-mertens please ignore this PR. It's for an internal demo in the SDK team. It will not be merged. Thank you! |
There was a problem hiding this comment.
Pull Request Overview
This PR regenerates the azure-healthinsights-radiologyinsights SDK from a local TypeSpec spec and introduces a new custom inference API. Key updates include:
- Added
begin_custom_inferencesupport (sync and async) with corresponding request builders. - Renamed
RadiologyInsightsClientOperationsMixinto a private_RadiologyInsightsClientOperationsMixinand adjusted client inheritance. - Fixed import-error pylint warnings and updated package namespace resolution in
setup.py.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/healthinsights/azure-healthinsights-radiologyinsights/setup.py | Switched to PACKAGE_NAMESPACE for folder path logic. |
| sdk/.../aio/_operations/_operations.py | Disabled import-error, added _custom_inference_initial and begin_custom_inference. |
| sdk/.../aio/_operations/init.py | Removed public mixin export (now private). |
| sdk/.../aio/_client.py | Updated base class to private mixin. |
| sdk/.../_utils/model_base.py | Added pylint disable on super().__new__ call. |
| sdk/.../_operations/_operations.py | Inserted build_radiology_insights_custom_inference_request and custom inference methods. |
| sdk/.../_operations/init.py | Removed public mixin export (now private). |
| sdk/.../_client.py | Updated base class to private mixin. |
| sdk/.../apiview-properties.json | Added apiview mappings for custom inference. |
Comments suppressed due to low confidence (2)
sdk/healthinsights/azure-healthinsights-radiologyinsights/azure/healthinsights/radiologyinsights/aio/_operations/_operations.py:297
- Add unit tests for
begin_custom_inferenceand_custom_inference_initialto validate request payloads, error mapping, and polling behavior in both sync and async clients.
async def _custom_inference_initial(
sdk/healthinsights/azure-healthinsights-radiologyinsights/azure/healthinsights/radiologyinsights/_operations/_operations.py:77
- Ensure that
_SERIALIZERis imported or defined in this module before it’s used inbuild_radiology_insights_custom_inference_request, otherwise you’ll encounter aNameErrorat runtime.
def build_radiology_insights_custom_inference_request(**kwargs: Any) -> HttpRequest: # pylint: disable=name-too-long
|
/azp run python - pullrequest |
|
Azure Pipelines successfully started running 1 pipeline(s). |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the azure-healthinsights-radiologyinsights Python SDK library using a local TypeSpec spec located at C:\Users\caperal\repos\azure-rest-api-specs\specification\ai\HealthInsights\HealthInsights.RadiologyInsights.
Changes
SDK Generation
Code Quality Fixes
Validation Status
All static validation checks now pass successfully:
Testing
The SDK has been updated and regenerated from the local spec. All static analysis tools pass without issues, indicating the code quality meets Azure SDK standards.
Checklist