-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix namespace parsing to correctly discover package namespaces instead of simple string replacement #41942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+167
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
api-view-parser
namespace parsing in azure-sdk-tools
Copilot finished work on behalf of
scbedd
July 8, 2025 18:19
scbedd
reviewed
Jul 8, 2025
scbedd
reviewed
Jul 8, 2025
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
…n review Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
Copilot finished work on behalf of
scbedd
July 8, 2025 18:38
scbedd
reviewed
Jul 8, 2025
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
scbedd
approved these changes
Jul 8, 2025
scbedd
approved these changes
Jul 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now.
mccoyp
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The namespace parsing in
parse_pyproject
andparse_setup_py
functions was using a naive approach of simply replacing-
with.
in package names to determine namespaces. This approach fails for packages with complex namespace structures.For example, the package
azure-eventhub-checkpointstoreblob
has:azure-eventhub-checkpointstoreblob
azure.eventhub.extensions.checkpointstoreblob
azure.eventhub.checkpointstoreblob
Changes Made
discover_namespace()
function - Walks through the package directory structure to find__init__.py
files and discovers the actual namespace by examining the module hierarchy_set_root_namespace()
helper - Determines if an__init__.py
file contains substantial content vs just namespace extension calls (likeextend_path
)parse_pyproject()
- Now uses namespace discovery before falling back to simple string replacementparse_setup_py()
- Enhanced metapackage handling to also use namespace discoveryValidation Results
azure-eventhub-checkpointstoreblob
now correctly resolves toazure.eventhub.extensions.checkpointstoreblob
The implementation follows the logic provided in the issue description and ensures robust namespace discovery while maintaining backward compatibility.
Fixes #41941.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.